Skip to content
Snippets Groups Projects

vkd3d-shader: Int64 support.

Merged Conor McCarthy requested to merge cmccarthy/vkd3d:shader_int64_2 into master
1 unresolved thread

Many of these patches are small, but the series can be split in two if necessary.

Edited by Conor McCarthy

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Conor McCarthy added 38 commits

    added 38 commits

    • b3889a80...803dfc12 - 25 commits from branch wine:master
    • 803dfc12...2a4cd97e - 3 earlier commits
    • 994bff0b - tests/shader-runner: Add 64-bit arithmetic tests.
    • 11eeaa69 - tests/shader-runner: Add 64-bit bitwise tests.
    • 64bb5e84 - vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability.
    • 7341ff9c - vkd3d: Pass int64 capability info to vkd3d-shader.
    • 524008f8 - vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
    • 9714adfd - vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
    • 8854726e - vkd3d-shader/spirv: Introduce a UINT64 component type.
    • d7add2d0 - vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
    • eaf73c18 - vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
    • 6bc976ea - vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().

    Compare with previous version

  • Conor McCarthy added 40 commits

    added 40 commits

    • 6bc976ea...45679a96 - 27 commits from branch wine:master
    • 45679a96...36677023 - 3 earlier commits
    • fdfffa83 - tests/shader-runner: Add 64-bit arithmetic tests.
    • c20bc1dd - tests/shader-runner: Add 64-bit bitwise tests.
    • e85d5440 - vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability.
    • b1049118 - vkd3d: Pass int64 capability info to vkd3d-shader.
    • c65816a0 - vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
    • 10f7f00b - vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
    • 81141dae - vkd3d-shader/spirv: Introduce a UINT64 component type.
    • 4511e7c5 - vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
    • 093a7497 - vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
    • ec1df14a - vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().

    Compare with previous version

  • Conor McCarthy changed the description

    changed the description

  • Conor McCarthy added 30 commits

    added 30 commits

    • ec1df14a...1015cc95 - 23 commits from branch wine:master
    • ce840682 - vkd3d: Pass int64 capability info to vkd3d-shader.
    • 9425cb64 - vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
    • 04e400f4 - vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
    • bdf8a5fe - vkd3d-shader/spirv: Introduce a UINT64 component type.
    • 849a99b3 - vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
    • 36cd56a8 - vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
    • c42f18a1 - vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().

    Compare with previous version

  • Conor McCarthy marked this merge request as ready

    marked this merge request as ready

  • Conor McCarthy changed the description

    changed the description

    • +        if (dst[0].reg.data_type == VKD3D_DATA_UINT64)
      +            uint_max_id = spirv_compiler_get_constant_uint64_vector(compiler, 0xffffffffffffffff, component_count);

      I don't think "0xffffffffffffffff" is portable/reliable as a 64-bit constant. We should probably use "UINT64_C(0xffffffffffffffff)", although you could probably make a case for either "UINT64_MAX" or "~(uint64_t)0" as well.

    • I'd vote for one of the last two, which are already used widely in the code base. Specifically, UINT64_MAX is my favourite.

    • Please register or sign in to reply
  • Giovanni Mascellani approved this merge request

    approved this merge request

  • Conor McCarthy added 30 commits

    added 30 commits

    • c42f18a1...f96a7918 - 23 commits from branch wine:master
    • b05243ae - vkd3d: Pass int64 capability info to vkd3d-shader.
    • 3d70832f - vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
    • 93d3c1f1 - vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
    • 70148a50 - vkd3d-shader/spirv: Introduce a UINT64 component type.
    • 424f2479 - vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
    • 9ae1e458 - vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
    • afeae9d9 - vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().

    Compare with previous version

  • Conor McCarthy added 7 commits

    added 7 commits

    • 6dd5871a - vkd3d: Pass int64 capability info to vkd3d-shader.
    • 82aa3318 - vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
    • de914b5b - vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
    • 07ba7a99 - vkd3d-shader/spirv: Introduce a UINT64 component type.
    • 54d47eb9 - vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
    • 9b92d4b6 - vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
    • 7a6a7eae - vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • added 7 commits

    • cc43ef3b - vkd3d: Pass int64 capability info to vkd3d-shader.
    • 511c66d5 - vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
    • fe448739 - vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
    • 13459a55 - vkd3d-shader/spirv: Introduce a UINT64 component type.
    • 99924d91 - vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
    • 1eaa7d1d - vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
    • 812f01c2 - vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

Please register or sign in to reply
Loading