Skip to content
Snippets Groups Projects

vkd3d-shader: Replace assert() with VKD3D_ASSERT(), part 4/4.

Merged Giovanni Mascellani requested to merge giomasce/vkd3d:flegrei into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Giovanni Mascellani approved this merge request

    approved this merge request

    • +========================
      +Preprocessor definitions
      +========================

      Should that just be a subsection of "Building vkd3d"? In any case, it seems a bit weird to have the "Using vkd3d" section between this section and "Building vkd3d".

      + * VKD3D_NO_DEBUG_MESSAGES - do not emit warn and fixme messages in the debug
      +   log; this will further optimize the binary, but you might miss messages that
      +   could help debugging problems with vkd3d.
      +
      +  * VKD3D_NO_ERROR_MESSAGES - do not emit error messages; this will optimize the
      +    binary even more, but you might miss very important messages, so it is not
      +    suggested in most circumstances.

      Some misalignment here.

      +  * VKD3D_SHADER_UNSUPPORTED_DXIL - enable DXIL support in vkd3d-shader, which
      +    is disabled by default because it is not considered ready for release yet.
      +
      +  * VKD3D_SHADER_UNSUPPORTED_GLSL - enable GLSL support in vkd3d-shader, which
      +    is disabled by default because it is not considered ready for release yet.

      The most crucial thing about these two is probably that future releases may break compatibility with the current behaviour.

    • Since Petra is already working on !984 (closed) I removed the last commit.

    • I am going to probably copy your work here for 984 if that's alright 😇

    • Of course it is! :-)

    • Great, cause I've already done it :)

    • Please register or sign in to reply
  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 24 commits

    added 24 commits

    • 1eaa5ef6...8c3a5e54 - 20 commits from branch wine:master
    • d5126b4d - vkd3d-shader: Replace assert() with VKD3D_ASSERT() in spirv.c.
    • 0294aa62 - vkd3d-shader: Replace assert() with VKD3D_ASSERT() in tpf.c.
    • 27bceec9 - vkd3d-shader: Replace assert() with VKD3D_ASSERT() in vkd3d_shader_main.c.
    • 8b6ab962 - vkd3d-shader: Replace assert() with VKD3D_ASSERT() in vkd3d_shader_private.h.

    Compare with previous version

Please register or sign in to reply
Loading