Skip to content
Snippets Groups Projects

vkd3d-shader/hlsl: Support default values for function parameters.

Merged Shaun Ren requested to merge shaunren/vkd3d:param-initializer into master
All threads resolved!

Merge request reports

Checking pipeline status.

Approved by

Merged by Henri VerbeetHenri Verbeet 8 months ago (Jul 23, 2024 1:43pm UTC)

Merge details

  • Changes merged into master with 49caeee1.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Francisco Casas
  • Francisco Casas
  • Nice patch, it never occurred to me that default_values could be used to parse parameter default values.

    Note that for future patches, when possible, it is desirable for tests to be introduced in a previous patch marked as todo and then the todo removed on the patch that contains the implementation.

    I am ready to approve once the other comments have been addressed.

  • Shaun Ren added 30 commits

    added 30 commits

    • 2e255f08...5a53b739 - 29 commits from branch wine:master
    • ce895ecd - vkd3d-shader/hlsl: Support default values for function parameters.

    Compare with previous version

  • Shaun Ren added 6 commits

    added 6 commits

    • ce895ecd...0202393d - 5 commits from branch wine:master
    • e2bb2127 - vkd3d-shader/hlsl: Support default values for function parameters.

    Compare with previous version

  • Shaun Ren resolved all threads

    resolved all threads

  • Shaun Ren added 1 commit

    added 1 commit

    • 7aa2a0c1 - vkd3d-shader/hlsl: Support default values for function parameters.

    Compare with previous version

  • Shaun Ren resolved all threads

    resolved all threads

  • Elizabeth Figura
  • Shaun Ren added 1 commit

    added 1 commit

    • 4f8bddf1 - vkd3d-shader/hlsl: Support default values for function parameters.

    Compare with previous version

  • Shaun Ren resolved all threads

    resolved all threads

  • Francisco Casas approved this merge request

    approved this merge request

  • Elizabeth Figura approved this merge request

    approved this merge request

  • Henri Verbeet approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading