vkd3d-shader/hlsl: Separate an "array" rule.
Merge request reports
Activity
added 13 commits
-
f0cd35b4...da1d96f7 - 12 commits from branch
wine:master
- 3c5dc1e5 - vkd3d-shader/hlsl: Separate an "array" rule.
-
f0cd35b4...da1d96f7 - 12 commits from branch
requested review from @fcasas
Not really important, but removing the
YYABORT
when encountering an error (which is a good thing), means that the array size0
, which happens on a failure to parse the uint constant, can be passed around generating spurious errors:int i; static const float4 array_st[i][i] = { 11, 12, 13, 14, 21, 22, 23, 24, }; float4 main() : SV_TARGET { return 0; }
simple.hlsl:3:32: E5000: Failed to evaluate constant expression. simple.hlsl:3:32: E5008: Array size is not a positive integer constant. simple.hlsl:3:38: E5000: Failed to evaluate constant expression. simple.hlsl:3:38: E5008: Array size is not a positive integer constant. simple.hlsl:3:21: E5002: Only innermost array size can be implicit. simple.hlsl:3:21: E5002: Cannot declare an implicit size array of a size 0 type.
Might be a good idea to add a
bool failed;
field tostruct parse_array_sizes
to differentiate between parse failure and implicit count.added 1 commit
- 6e91e6f2 - vkd3d-shader/hlsl: Separate an "array" rule.
added 32 commits
-
6e91e6f2...94130c23 - 31 commits from branch
wine:master
- 4cd2dd50 - vkd3d-shader/hlsl: Separate an "array" rule.
-
6e91e6f2...94130c23 - 31 commits from branch
Please register or sign in to reply