Skip to content
Snippets Groups Projects

tests: Check that derivatives are still computed after discarding.

Merged Giovanni Mascellani requested to merge giomasce/vkd3d:vulcano into master
2 unresolved threads

A couple of follow-ups to !774 (merged).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Giovanni Mascellani approved this merge request

    approved this merge request

    • Is the test working as intended? I would have expected this to require enabling the VK_EXT_shader_demote_to_helper_invocation for the Vulkan runner, as well as passing VKD3D_SHADER_SPIRV_EXTENSION_EXT_DEMOTE_TO_HELPER_INVOCATION in the SPIR-V target info for vkd3d_shader_compile().

    • I can see that the generates shaders have OpKill or OpDemoteToHelperInvocationEXT depending on whether they're on the Vulkan or D3D12 runner, but in practice the effect seems to be the same on all the drivers I tested. It doesn't look like that the SPIR-V specs tells a lot about what is ought to happen when derivatives are computer after OpKill, so I assume it's unspecified and drivers treat that as OpDemoteToHelperInvocationEXT anyway.

    • Please register or sign in to reply
    • I can see that the generates shaders have OpKill or OpDemoteToHelperInvocationEXT depending on whether they're on the Vulkan or D3D12 runner, but in practice the effect seems to be the same on all the drivers I tested. It doesn't look like that the SPIR-V specs tells a lot about what is ought to happen when derivatives are computer after OpKill, so I assume it's unspecified and drivers treat that as OpDemoteToHelperInvocationEXT anyway.

      I suppose, which is perhaps unfortunate. We should probably enable the extension in any case for the Vulkan runner to get defined behaviour though.

    • I did that. We're still feeding OpKill to the OpenGL runner, but apparently we don't have a choice there.

    • Please register or sign in to reply
  • added 1 commit

    • 21a58747 - tests/shader-runner: Use OpDemoteToHelperInvocationEXT when available.

    Compare with previous version

  • The Win32 test failure here looks like the random one fixed by !782 (merged).

  • added 53 commits

    • 21a58747...e17e4811 - 50 commits from branch wine:master
    • 2d4bf8a4 - tests: Avoid using a different UAV for SM<6 and SM>=6.
    • 5d19a7c7 - tests: Check that derivatives are still computed after discarding.
    • c318dd04 - tests/shader-runner: Use OpDemoteToHelperInvocationEXT when available.

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • added 9 commits

    • c318dd04...296edf0d - 6 commits from branch wine:master
    • 12c457b4 - tests: Avoid using a different UAV for SM<6 and SM>=6.
    • 7196484e - tests: Check that derivatives are still computed after discarding.
    • dbe3c00a - tests/shader-runner: Use OpDemoteToHelperInvocationEXT when available.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

Please register or sign in to reply
Loading