Skip to content
Snippets Groups Projects

vkd3d-shader: Remove a token for 'precise' modifier.

Merged Nikolay Sivov requested to merge nsivov/vkd3d:modifiers into master

Merge request reports

Merge request pipeline #23771 skipped

Merge request pipeline skipped for 948cd215

Merged by Alexandre JulliardAlexandre Julliard 1 year ago (Mar 12, 2024 9:58pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Unfortunately this doesn't quite work, because "precise" can also be a type. But changing var_identifier to any_identifier is going to run into shift/reduce conflicts. (There's no actual conflicts in the language, but there's not enough lookahead to know how to parse the first "precise" in e.g. "precise foobar".

      This may need to be handled on the lexer side, probably by keeping KW_PRECISE but only returning it if it's not defined as a specific identifier.

    • Author Developer

      What would be a test case for this? A test like this:

      precise float4 var;
      typedef float4 precise;
      
      precise main() : sv_target
      {
          return var;
      }

      is already working for me. Once 'precise' is defined as a type, it can't be used as a modifier.

    • Oh, you're right, that does work. So it's the other way around—that should probably be NEW_IDENTIFIER, not var_identifier. Unless you can use 'precise' as a modifier after you've declared it as a variable name?

    • Author Developer

      Yes, you can do that. That might be on purpose, for compatibility with existing sources, if this modifier was added in later versions. I'll add some more tests.

    • Please register or sign in to reply
  • Nikolay Sivov added 3 commits

    added 3 commits

    • ef1115df - vkd3d-shader: Remove a token for 'precise' modifier.
    • 92845f58 - vkd3d-shader: Parse a 'single' modifier.
    • a868de6f - vkd3d-shader/fx: Handle 'single' modifier for buffers.

    Compare with previous version

  • Elizabeth Figura approved this merge request

    approved this merge request

  • Matteo Bruni approved this merge request

    approved this merge request

  • Giovanni Mascellani approved this merge request

    approved this merge request

  • Henri Verbeet approved this merge request

    approved this merge request

  • Alexandre Julliard added 40 commits

    added 40 commits

    • a868de6f...f2b2040f - 37 commits from branch wine:master
    • cf7c05f4 - vkd3d-shader: Remove a token for 'precise' modifier.
    • e0ef45c0 - vkd3d-shader: Parse a 'single' modifier.
    • 948cd215 - vkd3d-shader/fx: Handle 'single' modifier for buffers.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

Please register or sign in to reply
Loading