Skip to content
Snippets Groups Projects

vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar and add more swizzle tests.

Merged Francisco Casas requested to merge fcasas/vkd3d:swizzle_index into master
1 unresolved thread

Vectors cannot be used as array indexes, however, single-component swizzles (such as vec.x) can be used.

This suggests that single-component swizzles should actually be scalars and not vectors of dimx = 1.

It is worth noting that the use of swizzles on scalars should still be allowed.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
116 116 {
117 117 float f = 20;
118 118
119 return f.x.x;
119 return f.x.x;
  • Francisco Casas added 3 commits

    added 3 commits

    • b97a2106 - tests: Test swizzles on scalar values.
    • 1c00c9f7 - tests: Add tests for assignments to self with swizzles.
    • 053a11da - vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar.

    Compare with previous version

  • Giovanni Mascellani approved this merge request

    approved this merge request

  • Elizabeth Figura approved this merge request

    approved this merge request

  • Henri Verbeet approved this merge request

    approved this merge request

  • added 15 commits

    • 053a11da...d2f8a576 - 10 commits from branch wine:master
    • dd216875 - tests: Combine all the swizzle tests in a single file.
    • 524029a0 - tests: Test using single-component swizzles as indexes.
    • 9d7ef64d - tests: Test swizzles on scalar values.
    • edf86b22 - tests: Add tests for assignments to self with swizzles.
    • f33ca836 - vkd3d-shader/hlsl: Make single-component swizzles retrieve a scalar.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading