hlsl: Improve condition type validation.
1 unresolved thread
Merge request reports
Activity
added 4 commits
Toggle commit listadded 5 commits
- 2bd69c6c - vkd3d-shader/hlsl: Copy some missing fields in hlsl_type_clone().
- fa0d7fa7 - vkd3d-shader/hlsl: Validate the condition data type for loops as well.
- 51a7fba8 - vkd3d-shader/hlsl: Validate that condition expressions are numeric.
- 0bd361d7 - vkd3d-shader/hlsl: Always cast to bool in if() statements.
- 1a9c3b0e - tests: Add tests for valid conditional types.
Toggle commit listadded 48 commits
-
1a9c3b0e...de9725b6 - 43 commits from branch
wine:master
- c18a349a - vkd3d-shader/hlsl: Copy some missing fields in hlsl_type_clone().
- 09220edd - vkd3d-shader/hlsl: Validate the condition data type for loops as well.
- 183172ef - vkd3d-shader/hlsl: Validate that condition expressions are numeric.
- a8b0c039 - vkd3d-shader/hlsl: Always cast to bool in if() statements.
- 57c4a130 - tests: Add tests for valid conditional types.
Toggle commit list-
1a9c3b0e...de9725b6 - 43 commits from branch
I just noticed that a8b0c039 makes test
switch.shader_test
fail on my M2 MacBook with MoltenVK 1.2.7. I haven't debugged that yet, but it seems pretty consistently reproducible. It doesn't seem to happen on the macOS CI runner (which is Intel-based, though).Specifically the failure is:
shader_runner:735: switch.shader_test:553: Test failed: Got {1.00000000e+00, 2.00000000e+00, 3.00000000e+00, 4.00000000e+00}, expected {7.00000000e+00, 8.00000000e+00, 9.00000000e+00, 1.00000000e+01} at (0, 0).
Edited by Giovanni Mascellani
Please register or sign in to reply