Skip to content
Snippets Groups Projects

vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.

Merged Conor McCarthy requested to merge cmccarthy/vkd3d:dxil_store into master
1 unresolved thread

Merge request reports

Checking pipeline status.

Approved by

Merged by Alexandre JulliardAlexandre Julliard 1 year ago (Dec 11, 2023 10:20pm UTC)

Merge details

  • Changes merged into master with af86cdf7.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
3101 {
3102 FIXME("Unhandled implicit type.\n");
3103 vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
3104 "Implicit result type for ALLOCA instructions is not supported.");
3105 return;
3106 }
3107 packed_operands &= ~(ALLOCA_FLAG_IN_ALLOCA | ALLOCA_FLAG_EXPLICIT_TYPE);
3108
3109 if (!sm6_type_is_array(type[0]) || !sm6_type_is_numeric(elem_type = type[0]->u.array.elem_type))
3110 {
3111 WARN("Type is not a numeric array.\n");
3112 vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
3113 "Result type of an ALLOCA instruction is not a numeric array.");
3114 return;
3115 }
3116 if (!sm6_type_is_integer(type[1]))
  • Giovanni Mascellani approved this merge request

    approved this merge request

  • Conor McCarthy added 4 commits

    added 4 commits

    • 494a07a5 - vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction.
    • 7ba2ba61 - vkd3d-shader/dxil: Implement the DXIL STORE instruction.
    • 113c9601 - vkd3d-shader/spirv: Bitcast if necessary in the spirv_compiler_emit_mov() general implementation.
    • 1b51103f - tests/shader-runner: Add a non-const-indexing test for asfloat() result storage.

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • Alexandre Julliard approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading