vkd3d-shader/hlsl: More miscelaneous fixes.
2 unresolved threads
2 unresolved threads
Just a few miscellaneous fixes I think are simple enough to make it into the next version.
Merge request reports
Activity
3345 3345 } 3346 3346 3347 3347 buffer_body: 3348 '{' declaration_statement_list '}' 3348 '{' '}' 3349 { 3350 ctx->cur_buffer = ctx->globals_buffer; 3351 } 3352 | '{' declaration_statement_list '}' Ah, I attempted to do:
declaration_statement_list: %empty | declaration_statement | declaration_statement_list declaration_statement
so there where two possible reductions for the first declaration statement.
Removing the
| declaration_statement
rule works:declaration_statement_list: %empty | declaration_statement_list declaration_statement
So I am going for that.
changed this line in version 3 of the diff
Ugh, and now that I notice it we're also leaking / failing to handle declaration_statement here. Annoying that bison doesn't warn here when declaration_statement_list has no type but declaration_statement does.
To be clear that's a preëxisting problem, doesn't need a fix in this patch set.
added 4 commits
- f1e175cf - tests: Add missing entry for max.shader_test in Makefile.am
- 7349f2cf - vkd3d-shader/hlsl: Check for non-static object references on resource stores.
- e58ddccb - vkd3d-shader/hlsl: Don't produce a parse error on empty buffer_body.
- 3372940f - vkd3d-shader/hlsl: Revert expr_compatible_data_types() args names to "t1" and "t2".
Toggle commit listadded 4 commits
- dd100886 - tests: Add missing entry for max.shader_test in Makefile.am.
- f100f5b7 - vkd3d-shader/hlsl: Check for non-static object references on resource stores.
- bd501ce3 - vkd3d-shader/hlsl: Don't produce a parse error on empty buffer_body.
- 43631bde - vkd3d-shader/hlsl: Revert expr_compatible_data_types() args names to "t1" and "t2".
Toggle commit list
Please register or sign in to reply