Skip to content
Snippets Groups Projects

vkd3d-shader/spirv: Do not write the point size if shaderTessellationAndGeometryPointSize is disabled.

Merged Elizabeth Figura requested to merge zfigura/vkd3d:pr0 into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • I'm a bit undecided on VKD3D_SHADER_SPIRV_FEATURE_TESSELLATION_AND_GEOMETRY_POINT_SIZE. I don't hate it, but also can't help wondering whether it's the best we can do.

    • It makes a lot of intuitive sense to me, in general, to treat features and extensions the same way. I don't think any better designs occur to me.

      Of course, we already started down a different path with shaderStorageImageReadWithoutFormat in 3dbd2cec. I still am not sure that was the best option, but perhaps we should just be consistent...

    • Please register or sign in to reply
  • It makes a lot of intuitive sense to me, in general, to treat features and extensions the same way. I don't think any better designs occur to me.

    Of course, we already started down a different path with shaderStorageImageReadWithoutFormat in 3dbd2cec. I still am not sure that was the best option, but perhaps we should just be consistent...

    That, but also whether it's really worth it to change the default value of this between releases. Those aren't entirely independent choices, of course; using the extension mechanism makes it a bit awkward to keep this enabled by default like it was in previous versions.

  • Elizabeth Figura added 107 commits

    added 107 commits

    • 4b04fb7a...68c232cf - 105 commits from branch wine:master
    • 7f928a35 - vkd3d-shader/spirv: Introduce an option to control whether point size is written.
    • 2848d7b6 - vkd3d: Do not write the point size for SPIR-V shaders.

    Compare with previous version

  • I've rewritten this with an option instead, to avoid changing the default value.

  • Henri Verbeet approved this merge request

    approved this merge request

  • added 3 commits

    • 06f300ec - 1 commit from branch wine:master
    • 8fc8d34e - vkd3d-shader/spirv: Introduce an option to control whether point size is written.
    • a66fe31f - vkd3d: Do not write the point size for SPIR-V shaders.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

Please register or sign in to reply
Loading