Skip to content
Snippets Groups Projects

ci: Run the crosstests on Windows.

Merged Giovanni Mascellani requested to merge giomasce/vkd3d:stromboli into master
2 unresolved threads

This depends on !412 (merged), and might need some finishing touches before being ready.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
tests/driver.c 0 → 100644
74 goto out;
75 }
76
77 if (WaitForSingleObject(info.hProcess, INFINITE) != WAIT_OBJECT_0)
78 {
79 fprintf(stderr, "Cannot wait for process termination, last error %ld.\n", GetLastError());
80 ret = false;
81 goto out;
82 }
83
84 if (!GetExitCodeProcess(info.hProcess, &exit_code))
85 {
86 fprintf(stderr, "Cannot retrive the process exit code, last error %ld.\n", GetLastError());
87 ret = false;
88 goto out;
89 }
  • Comment on lines +76 to +89

    This should have a (short) timeout and then kill the process, like winetest.exe does. We can't have a runaway test block the runner for an hour.

  • Yeah, it makes sense. Actually, it already happens every now and then with the macOS tests, so it wouldn't be bad to have something similar there too.

  • Is this solution acceptable? It trusts that WaitForSingleObject() after TerminateProcess() returns in short time, in the spirit of wait() on Unix. Or should I just close the handle without waiting for the process if I terminate it?

  • Please register or sign in to reply
  • added 2 commits

    • 81beeea8 - ci: Run cross tests on Windows.
    • b6b634ba - ci: Run shader tests on Windows.

    Compare with previous version

  • added 2 commits

    • be88f85d - ci: Run cross tests on Windows.
    • ea44528b - ci: Run shader tests on Windows.

    Compare with previous version

  • added 2 commits

    • 3aa24362 - ci: Run cross tests on Windows.
    • 3e3da6ad - ci: Run shader tests on Windows.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading