Skip to content
Snippets Groups Projects

vkd3d: Add partial implementation for CreateCommittedResource1().

Merged Nikolay Sivov requested to merge nsivov/vkd3d:createcommittedresource1 into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1837 1838 ok(hr == E_INVALIDARG, "Test %u: Got unexpected hr %#x.\n", i, hr);
1838 1839 }
1839 1840
1841 if (SUCCEEDED(ID3D12Device_QueryInterface(device, &IID_ID3D12Device4, (void **)&device4)))
  • Giovanni Mascellani approved this merge request

    approved this merge request

  • Do we have a way to annotate a condition so that it's always expected to pass for vkd3d, even if it can fail for native? It would be something that we want here.

    Not as such, but Wine's win_skip() behaves like that, and it shouldn't be hard to introduce something similar for vkd3d. Another common approach would be to add something like "ok(hr == S_OK || broken(1), ...);" for the result of the QueryInterface() call.

    I'm not too worried about this specific case though. In theory there's a chance that we could drop the ID3D12Device4 interface and not notice, but in practice that wouldn't be an especially subtle change.

  • Henri Verbeet approved this merge request

    approved this merge request

  • added 2 commits

    • 72e8b6e0 - 1 commit from branch wine:master
    • 9c6c7cb7 - vkd3d: Add partial implementation for CreateCommittedResource1().

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading