Skip to content
Snippets Groups Projects

vkd3d: Add ID3D12Device4 interface stub.

Merged Andrey Gusev requested to merge agusev/vkd3d:interface into master
1 unresolved thread

Merge request reports

Merge request pipeline #15782 skipped

Merge request pipeline skipped for acd3ed97

Merged by Alexandre JulliardAlexandre Julliard 1 year ago (Sep 27, 2023 9:00pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • +static D3D12_RESOURCE_ALLOCATION_INFO * STDMETHODCALLTYPE d3d12_device_GetResourceAllocationInfo1(
      +        ID3D12Device4 *iface, D3D12_RESOURCE_ALLOCATION_INFO *info, UINT visible_mask,
      +        UINT count, const D3D12_RESOURCE_DESC *resource_descs,
      +        D3D12_RESOURCE_ALLOCATION_INFO1 *info1)
      +{
      +    FIXME("iface %p, info %p, visible_mask 0x%08x, count %u, resource_descs %p, info1 %p stub!\n",
      +            iface, info, visible_mask, count, resource_descs, info1);
      +
      +    return E_NOTIMPL;
      +}

      This introduces warnings; E_NOTIMPL doesn't match the "D3D12_RESOURCE_ALLOCATION_INFO *" return type. This can also be seen in the CI logs, although CI didn't fail on this. (@giomasce Should we be building with -Werror on configurations that currently build without warnings?)

    • (@giomasce Should we be building with -Werror on configurations that currently build without warnings?)

      Yeah, it's something I had already thought about. I'll remember to enable that with the next MR.

    • Please register or sign in to reply
  • Andrey Gusev added 1 commit

    added 1 commit

    • 29d9404c - vkd3d: Add ID3D12Device4 interface stub.

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • Alexandre Julliard added 11 commits

    added 11 commits

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

Please register or sign in to reply
Loading