vkd3d-shader/hlsl: Initial support for 'switch' statement.
Signed-off-by: Nikolay Sivov nsivov@codeweavers.com
Merge request reports
Activity
added 1 commit
- d3918848 - vkd3d-shader/hlsl: Initial support for 'switch' statement.
- Resolved by Nikolay Sivov
You have already !245 (merged) open and waiting on your iteration, which is also about control flow and partially overlapping with this one. What's holding back that one? Could you please first finish that and then submit this one?
- Resolved by Nikolay Sivov
- Resolved by Nikolay Sivov
- Resolved by Nikolay Sivov
added 118 commits
-
d3918848...014960b6 - 116 commits from branch
wine:master
- 9a743fb2 - vkd3d-shader/hlsl: Parse 'break' statement.
- 157b581b - vkd3d-shader/hlsl: Initial support for 'switch' statement.
-
d3918848...014960b6 - 116 commits from branch
added 1 commit
- 7078b4da - vkd3d-shader/hlsl: Initial support for 'switch' statement.
added 20 commits
-
6900c622...6a942581 - 18 commits from branch
wine:master
- 76843870 - vkd3d-shader/hlsl: Initial support for 'switch' statement.
- d9e404cc - vkd3d-shader/tpf: Write out 'switch' statements.
-
6900c622...6a942581 - 18 commits from branch
- Resolved by Nikolay Sivov
commit 76843870bb94c5e6c95384c788d4842f3c7b142e Author: Nikolay Sivov <nsivov@codeweavers.com> Date: Wed Sep 20 11:53:36 2023 +0200 vkd3d-shader/hlsl: Initial support for 'switch' statement. Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Makefile.am | 1 + libs/vkd3d-shader/hlsl.c | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ libs/vkd3d-shader/hlsl.h | 31 ++++++++++++++++++++++++++++ libs/vkd3d-shader/hlsl.l | 4 +++- libs/vkd3d-shader/hlsl.y | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------- libs/vkd3d-shader/hlsl_codegen.c | 220 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- tests/hlsl/switch.shader_test | 272 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 777 insertions(+), 12 deletions(-)
I think that can be spread in at least five different commits, the first of which would just introduce
switch.shader_test
and nothing else. I think it's ok to introduce functions as stubs because you need them for earlier commits to compile and avoid crashing, and expanding them to full implementations in later commits. The target here is to make code introduction as incremental as possible, to help reviewers understanding what's going on.
added 4 commits
-
d9e404cc...9c6c7cb7 - 2 commits from branch
wine:master
- 275c9460 - vkd3d-shader/hlsl: Initial support for 'switch' statement.
- 30f39572 - vkd3d-shader/tpf: Write out 'switch' statements.
-
d9e404cc...9c6c7cb7 - 2 commits from branch
added 8 commits
- 74c0ac1b - tests: Add some tests for the 'switch' statements.
- 8d491a8c - vkd3d-shader/hlsl: Add initial support for parsing 'switch' statements.
- 520a0265 - vkd3d-shader/hlsl: Check for duplicate case statements.
- 87250fea - vkd3d-shader/hlsl: Validate break/continue context.
- f1b6b81e - vkd3d-shader/hlsl: Add copy propagation logic for switches.
- 6837cb79 - vkd3d-shader/hlsl: Add a pass to remove unreachable code.
- b80922d1 - vkd3d-shader/hlsl: Add a pass to validate switch cases blocks.
- 3888a7dd - vkd3d-shader/tpf: Write out 'switch' statements.
Toggle commit list- Resolved by Nikolay Sivov
- Resolved by Nikolay Sivov
- Resolved by Nikolay Sivov
- Resolved by Nikolay Sivov
- Resolved by Nikolay Sivov