Skip to content
Snippets Groups Projects

Fill in more missing details in d3d12.idl

Merged Martin Storsjö requested to merge mstorsjo/vkd3d:d3d12-fillin into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Storsjö added 2 commits

    added 2 commits

    • 9296ec45 - include: Add DirectX 12 Agility SDK definitions.
    • e46eada1 - include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces.

    Compare with previous version

  • Martin Storsjö added 3 commits

    added 3 commits

    • b78ac338 - include: Add DirectX 12 Agility SDK definitions.
    • bd04c6ab - include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces.
    • b0a057b9 - include: Add UUIDs for use with D3D12EnableExperimentalFeatures.

    Compare with previous version

  • Martin Storsjö added 3 commits

    added 3 commits

    • 0ec20e90 - include: Add DirectX 12 Agility SDK definitions.
    • ed5edeab - include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces.
    • cc79260c - include: Add UUIDs for use with D3D12EnableExperimentalFeatures.

    Compare with previous version

    • A couple of minor comments:

      +typedef enum D3D12_SHADING_RATE_COMBINER
      +{
      +    D3D12_SHADING_RATE_COMBINER_PASSTHROUGH = 0,
      +    D3D12_SHADING_RATE_COMBINER_OVERRIDE = 1,
      +    D3D12_SHADING_RATE_COMBINER_MIN = 2,
      +    D3D12_SHADING_RATE_COMBINER_MAX = 3,
      +    D3D12_SHADING_RATE_COMBINER_SUM = 4,
      +} D3D12_SHADING_RATE_COMBINER;

      It doesn't matter much here, but it seems some decimals slipped through.

      +cpp_quote("#define D3D12_SHADING_RATE_X_AXIS_SHIFT 2")
      +cpp_quote("#define D3D12_SHADING_RATE_VALID_MASK 3")

      Should that just use the following?

      const UINT D3D12_SHADING_RATE_X_AXIS_SHIFT = 2;
      const UINT D3D12_SHADING_RATE_VALID_MASK = 3;
      +cpp_quote("#define D3D12_MAKE_COARSE_SHADING_RATE(x,y) ((x) << D3D12_SHADING_RATE_X_AXIS_SHIFT | (y))")

      "D3D12_MAKE_COARSE_SHADING_RATE(x, y)"

      +cpp_quote("#define D3D12_GET_COARSE_SHADING_RATE_Y_AXIS(y) ((y) & D3D12_SHADING_RATE_VALID_MASK)")

      The choice of "y" for the macro parameter is a bit odd, I think. The macro extracts the y-axis value; the input would be a combined x and y shading rate value like those produced by D3D12_MAKE_COARSE_SHADING_RATE.

    • Author Contributor

      Thanks for the review.

      I made that one enum use hexadecimal constants too, changed the #defines for plain constants into regular IDL-level constants, and changed the macro parameters x and y into val for the macros that extract the x or y value out of a combined value.

    • Please register or sign in to reply
  • Martin Storsjö added 2 commits

    added 2 commits

    • 98c7d77b - include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces.
    • 1e4b0427 - include: Add UUIDs for use with D3D12EnableExperimentalFeatures.

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • added 5 commits

    • 1e4b0427...da89da2b - 2 commits from branch wine:master
    • 5d13a90e - include: Add DirectX 12 Agility SDK definitions.
    • b484a9e1 - include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces.
    • e597b0d8 - include: Add UUIDs for use with D3D12EnableExperimentalFeatures.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

Please register or sign in to reply
Loading