Skip to content
Snippets Groups Projects

vkd3d-shader/ir: Validate destination parameters.

Merged Giovanni Mascellani requested to merge giomasce/vkd3d:aso into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Giovanni Mascellani approved this merge request

    approved this merge request

  • added 6 commits

    • e6f01b6a - vkd3d-shader/ir: Represent information about I/O registers with a table.
    • 731deb0f - vkd3d-shader/ir: Validate INPUT destination parameters using a uniform helper.
    • c7a857c6 - vkd3d-shader/ir: Validate PATCHCONST destination parameters using a uniform helper.
    • 051f9686 - vkd3d-shader/ir: Validate OUTPUT destination parameters.
    • 253290ef - vkd3d-shader/ir: Validate INCONTROLPOINT destination parameters.
    • fd2e3e97 - vkd3d-shader/ir: Validate OUTCONTROLPOINT destination parameters.

    Compare with previous version

    • I think the basic idea here is fine, but I don't especially like the bool "valid_input"/"valid_output"/"has_control_point" flags. Could we e.g. make that a single "flags" field along the lines of what we did for e.g. struct sysval_validation_data_element, or even a string along the lines of "dst_info"/"src_info" in struct vkd3d_sm4_opcode_info if we're especially concerned about brevity? I'm not too keen on the vsir_io_register_data_set typedef either.

    • Hopefully it's better now.

    • Please register or sign in to reply
  • added 6 commits

    • e9ac321e - vkd3d-shader/ir: Represent information about I/O registers with a table.
    • 0896b6cb - vkd3d-shader/ir: Validate INPUT destination parameters using a uniform helper.
    • d1bd9546 - vkd3d-shader/ir: Validate PATCHCONST destination parameters using a uniform helper.
    • c96f9420 - vkd3d-shader/ir: Validate OUTPUT destination parameters.
    • 9202a4a4 - vkd3d-shader/ir: Validate INCONTROLPOINT destination parameters.
    • f6b001d7 - vkd3d-shader/ir: Validate OUTCONTROLPOINT destination parameters.

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 19 commits

    added 19 commits

    • f6b001d7...27c77769 - 13 commits from branch wine:master
    • 8d4b790e - vkd3d-shader/ir: Represent information about I/O registers with a table.
    • 38a5c905 - vkd3d-shader/ir: Validate INPUT destination parameters using a uniform helper.
    • b194e5dc - vkd3d-shader/ir: Validate PATCHCONST destination parameters using a uniform helper.
    • 7d87b4e8 - vkd3d-shader/ir: Validate OUTPUT destination parameters.
    • 3dc7f322 - vkd3d-shader/ir: Validate INCONTROLPOINT destination parameters.
    • 00538c37 - vkd3d-shader/ir: Validate OUTCONTROLPOINT destination parameters.

    Compare with previous version

Please register or sign in to reply
Loading