tests: Do not try to create a device if Vulkan extensions are not available.
The test is able to handle failures, but on the CI we use VKD3D_ABORT_ON_ERR, which causes the test program to exit with a failure anyway.
Another way to address that would to change ERR()
s in vkd3d_create_instance()
to WARN()
s. I don't have a strong preference.
Merge request reports
Activity
The test is able to handle failures, but on the CI we use VKD3D_ABORT_ON_ERR, which causes the test program to exit with a failure anyway.
And we don't have VK_KHR_surface because the CI uses a headless setup, I assume.
Another way to address that would to change
ERR()
s invkd3d_create_instance()
toWARN()
s. I don't have a strong preference.I think we used ERR there for visibility over WARN, but these days we could also use MESSAGE instead. It does seem slightly nicer to avoid abusing ERR.
And we don't have VK_KHR_surface because the CI uses a headless setup, I assume.
More precisely, because our custom Mesa built is compiled without WSI (at some point I looked into that, and I think I'd have to add a lot of other dependencies to the image to have WSI; given that in practice we don't use it, and that it's also valuable to test these corner cases, I don't think we should add it).
added 1 commit
- a7a0cba5 - vkd3d/device: WARN() rather than ERR() in vkd3d_instance_init().
added 7 commits
-
a7a0cba5...c010fb63 - 6 commits from branch
wine:master
- f9d73f5c - vkd3d/device: WARN() rather than ERR() in vkd3d_instance_init().
-
a7a0cba5...c010fb63 - 6 commits from branch
added 1 commit
- 72394d9a - vkd3d: Use WARN rather than ERR in vkd3d_instance_init().