Skip to content
Snippets Groups Projects

vkd3d-shader/hlsl: Store SM4 semantic declarations in the vsir program.

Merged Shaun Ren requested to merge shaunren/vkd3d:sm4-vsir-dcl-semantic into master
All threads resolved!

Currently, there is a bug where some semantic declarations are missing in the control point phase in hull shaders, because the liveness information of variables are overwritten when processing the VSIR program of the patch constant function. This bug can be resolved by moving the semantic declarations to the respective vsir programs.

Edited by Shaun Ren

Merge request reports

Merge request pipeline #34140 skipped

Merge request pipeline skipped for 64c4a3a4

Approval is optional

Merged by Henri VerbeetHenri Verbeet 5 months ago (Nov 5, 2024 7:05pm UTC)

Merge details

  • Changes merged into master with 64c4a3a4.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I see, makes sense. Thanks!

    I am ready to approve after the cases are sorted alphabetically.

  • Francisco Casas requested changes

    requested changes

  • Shaun Ren added 1 commit

    added 1 commit

    • 453f3319 - vkd3d-shader/hlsl: Store SM4 semantic declarations in the vsir program.

    Compare with previous version

  • Shaun Ren resolved all threads

    resolved all threads

  • Francisco Casas approved this merge request

    approved this merge request

  • Elizabeth Figura approved this merge request

    approved this merge request

  • Shaun Ren added 18 commits

    added 18 commits

    • 453f3319...794f4c30 - 17 commits from branch wine:master
    • eb3680a1 - vkd3d-shader/hlsl: Store SM4 semantic declarations in the vsir program.

    Compare with previous version

  • Author Contributor

    Rebased.

  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 2 commits

    added 2 commits

    • 5ea946aa - 1 commit from branch wine:master
    • 64c4a3a4 - vkd3d-shader/hlsl: Store SM4 semantic declarations in the vsir program.

    Compare with previous version

  • Please register or sign in to reply
    Loading