Skip to content
Snippets Groups Projects

vkd3d-shader/hlsl: Implement RWByteAddressBuffer.Store*() methods.

Merged Nikolay Sivov requested to merge nsivov/vkd3d:uav_raw2 into master
1 unresolved thread

Signed-off-by: Nikolay Sivov nsivov@codeweavers.com

Merge request reports

Merge request pipeline #33912 skipped

Merge request pipeline skipped for 89e5912f

Approval is optional

Merged by Henri VerbeetHenri Verbeet 5 months ago (Oct 28, 2024 5:12pm UTC)

Merge details

  • Changes merged into with 89e5912f.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • This is another commit that does two things (introduces RWByteAddressBuffer, and then implements its Store() method.) There's probably not any point splitting it now, but in the future please try to split these kinds of functional changes before sending.

      > +    else if (!strcmp(name, "Store2"))
      > +        value_dim = 2;
      > +    else if (!strcmp(name, "Store3"))
      > +        value_dim = 3;
      > +    else
      > +        value_dim = 4;

      None of these variants are tested; could we please have at least one test for each?

      > +    if (!(offset = add_cast(ctx, block, params->args[0], hlsl_get_scalar_type(ctx, HLSL_TYPE_UINT), loc)))
      > +        return false;
      > +
      > +    if (!(rhs = add_cast(ctx, block, params->args[1], hlsl_get_vector_type(ctx, HLSL_TYPE_UINT, value_dim), loc)))
      > +        return false;

      These should be add_implicit_conversion().

    • Author Developer

      Thanks. It's now split up, and both comments are addressed.

    • Please register or sign in to reply
  • Nikolay Sivov added 15 commits

    added 15 commits

    • c48a06d5...5eff8bf9 - 11 commits from branch wine:master
    • 0870e732 - vkd3d-shader/hlsl: Use more compact way to store object method configuration.
    • f9f598f1 - vkd3d-shader/hlsl: Add parser support for the RWByteAddressBuffer type.
    • 018b592f - tests: Add some more tests for RWByteAddressBuffer store methods.
    • bbd3b470 - vkd3d-shader/hlsl: Implement RWByteAddressBuffer.Store*() methods.

    Compare with previous version

  • Elizabeth Figura approved this merge request

    approved this merge request

  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 25 commits

    added 25 commits

    • bbd3b470...f7bc30ba - 21 commits from branch wine:master
    • 4195a2f1 - vkd3d-shader/hlsl: Use a more compact way to store object method configurations.
    • cf27065b - vkd3d-shader/hlsl: Add parser support for the RWByteAddressBuffer type.
    • 6637948a - tests: Add some more tests for RWByteAddressBuffer store methods.
    • 89e5912f - vkd3d-shader/hlsl: Implement RWByteAddressBuffer.Store*() methods.

    Compare with previous version

Please register or sign in to reply
Loading