Skip to content
Snippets Groups Projects

vkd3d-shader/hlsl: Implement basic hull shader support, part 2/2.

Merged Shaun Ren requested to merge shaunren/vkd3d:hs-basic/part-3/for-review into master
All threads resolved!

Merge request reports

Merge request pipeline #33392 skipped

Merge request pipeline skipped for 1ed5f1a4

Approved by

Merged by Henri VerbeetHenri Verbeet 6 months ago (Oct 16, 2024 7:47pm UTC)

Merge details

  • Changes merged into master with 1ed5f1a4.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shaun Ren added 8 commits

    added 8 commits

    • e777c1d1 - vkd3d-shader/tpf: Write hull shader declarations.
    • d846f5a7 - vkd3d-shader/tpf: Implement semantics for hull shaders.
    • c11eb89e - tests: Test hull shader uniform input parameters.
    • d09600d4 - vkd3d-shader/hlsl: Process the patch constant function in hlsl_emit_bytecode().
    • 7cec8a11 - vkd3d-shader/tpf: Introduce helper write_sm4_shader_function().
    • 4cc97a84 - vkd3d-shader/tpf: Determine SIV from SV and index in write_sm4_dcl_semantic().
    • 9afcfc31 - tests: Test signature reflection for hull shaders.
    • 97048d9e - vkd3d-shader/tpf: Write the patch constant function in hull shaders.

    Compare with previous version

  • Elizabeth Figura approved this merge request

    approved this merge request

    • Resolved by Shaun Ren

      It doesn't yet, but note that as soon as the hull shader in test_emit_signature() in vkd3d_shader_api.c compiles you're also welcome to remove the corresponding DXBC binary blob there (and similarly for the other shaders that still have a binary blob). Also, if you're dealing with signatures and see other corner cases that might make sense there, please feel welcome to add them. :-)

  • Shaun Ren resolved all threads

    resolved all threads

  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 21 commits

    added 21 commits

    • 97048d9e...47fcbc33 - 13 commits from branch wine:master
    • beb342ed - vkd3d-shader/tpf: Write hull shader declarations.
    • cbed70c6 - vkd3d-shader/tpf: Implement semantics for hull shaders.
    • aee00ea5 - tests: Test hull shader uniform input parameters.
    • 147f8898 - vkd3d-shader/hlsl: Process the patch constant function in hlsl_emit_bytecode().
    • df3aaac7 - vkd3d-shader/tpf: Introduce tpf_write_shader_function().
    • ae2d86b9 - vkd3d-shader/tpf: Determine SIV from SV and index in write_sm4_dcl_semantic().
    • f771f081 - tests: Test signature reflection for hull shaders.
    • 1ed5f1a4 - vkd3d-shader/tpf: Write the patch constant function in hull shaders.

    Compare with previous version

Please register or sign in to reply
Loading