Skip to content
Snippets Groups Projects

vkd3d-shader/ir: Validate signatures, part 3/N.

Merged Giovanni Mascellani requested to merge giomasce/vkd3d:vulcano into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Giovanni Mascellani approved this merge request

    approved this merge request

  • added 6 commits

    • 7815267c - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_Position.
    • eb0c3062 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_Position.
    • 100135e6 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_ClipDistance.
    • c549dbf2 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_ClipDistance.
    • 9e7344cd - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_CullDistance.
    • 8cd59051 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_CullDistance.

    Compare with previous version

  • I made a check a bit weaker, because it seems that native compilers are willing to generate signature masks for system values that are not "padded to x", even if actual access is "padded to x". So it seems that the signature mask is to be ignored for system values signature elements, which is also what the SPIR-V backend does. See for example https://shader-playground.timjones.io/1a3d99c09a65eddec1cb4029c65c675e: SV_TessFactor signature elements have bitmask w, but all accesses are always .x.

  • added 14 commits

    • 8cd59051...cd249a47 - 8 commits from branch wine:master
    • 87d7ed22 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_Position.
    • 485d43ae - vkd3d-shader/ir: Validate the allowed data type and component count for SV_Position.
    • c818c197 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_ClipDistance.
    • b5b35ce1 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_ClipDistance.
    • 8e103b05 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_CullDistance.
    • 392cf6b7 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_CullDistance.

    Compare with previous version

  • added 6 commits

    • 7d041bdb - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_Position.
    • 01e5704e - vkd3d-shader/ir: Validate the allowed data type and component count for SV_Position.
    • d369e6ba - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_ClipDistance.
    • 386ef660 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_ClipDistance.
    • 95418b82 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_CullDistance.
    • 6e7bff92 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_CullDistance.

    Compare with previous version

  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 18 commits

    added 18 commits

    • 6e7bff92...2d452842 - 12 commits from branch wine:master
    • 962ce961 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_Position.
    • 20b3a4c3 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_Position.
    • 0465549c - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_ClipDistance.
    • 33972998 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_ClipDistance.
    • cd5718f5 - vkd3d-shader/ir: Validate the allowed signatures and stages for SV_CullDistance.
    • 5dfaa269 - vkd3d-shader/ir: Validate the allowed data type and component count for SV_CullDistance.

    Compare with previous version

Please register or sign in to reply
Loading