Skip to content
Snippets Groups Projects

dwrite: Use Noto Sans as fallback for General and Supplemental Punctuation.

Closed Daniel Lehman requested to merge dlehman25/wine:dwrite into master
1 unresolved thread

Merge request reports

Merge request pipeline #38656 failed

Merge request pipeline failed for 582a4ecc

Approval is optional

Closed by Daniel LehmanDaniel Lehman 4 days ago (Apr 5, 2025 6:30pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • **** requested review from @nsivov

    requested review from @nsivov

    • I'm attaching a revised version for CJK locales, it has to use consistent font in such cases.dwrite.diff Note that it's excluding 202F because it's handled explicitly together with Mongolian ranges.

      This does not cover all of your changes. We need a non-locale specific entry for the same set "2000-202E, 2030-206F, 2E00-2E44". Now that has options, we could use Tahoma for those (Windows font does cover this), or we could switch all existing "common" ranges (first entry in this list) to Noto Sans. A variant of this second option is to use both names - "Tahoma, Noto Sans". Switching to Noto Sans will switch UI font in some cases, when applications are using e.g. Segoe UI that we don't have; this will be a visible change potentially for users who are used to current setup.

    • Author Contributor

      Now that has options

      have a preference?

      A variant of this second option is to use both names - "Tahoma, Noto Sans"

      you mean something like?

           /* Latin, Combining Diacritical Marks */
           { "0000-007F, 0080-00FF, 0100-017F, 0180-024F, "
      -      "0250-02AF, 02B0-02FF, 0300-036F", L"Tahoma" },
      +      "0250-02AF, 02B0-02FF, 0300-036F, "
      +      "2000-202E, 2030-206F, 2E00-2E44", L"Tahoma, Noto Sans" },
       
           { "0530-058F, FB10-FB1C",   L"Noto Sans Armenian" },
    • Yes, exactly. Regarding preferred way, if we use Tahoma with additional ranges we'll get null glyphs when we miss some glyph in wine's Tahoma. If we use both names we'll have potentially text switching from one font to another for no obvious reason to the user. If we use Noto Sans for everything, all ranges will work, but this will change default config that we had so far.

      Maybe we could use "Noto Sans, Tahoma" instead? Does that make sense? On mac for example you're not going to get Noto Sans semi-automatically.

      What is your use case, do you need anything from those ranges or you only need non-null font instance?

    • Author Contributor

      Maybe we could use "Noto Sans, Tahoma" instead? Does that make sense?

      seems consistent with the other entries that use Noto Sans

      What is your use case, do you need anything from those ranges

      0x2e2e prompted the change, but would like to add a general range

    • Both Noto Sans and Tahoma (on Windows) have it, so let's go with "Noto Sans, Tahoma" and see how it goes.

    • Please register or sign in to reply
  • Daniel Lehman added 39 commits

    added 39 commits

    • 4d86f192...d17225a8 - 38 commits from branch wine:master
    • 582a4ecc - dwrite: Use Noto Sans as fallback for General and Supplemental Punctuation.

    Compare with previous version

  • Unfortunately this breaks tests.

  • closed

Please register or sign in to reply
Loading