Skip to content
Snippets Groups Projects

Fix substring operation in 'magic' variable expansion.

Merged eric pouech requested to merge epo/wine:mr-cmd-substring into master

In substring expansion of variables, the length computation wasn't the same between:

  • magic variables: length doesn't include terminating NUL
  • regular variables: length does include terminating NUL This led to incorrect substring operation for magic variables. Always set length to not include terminating NUL. Took the opportunity to not recompute length (as it's already computed by called functions).

Merge request reports

Merge request pipeline #24702 skipped

Merge request pipeline skipped for 7f60584a

Approval is optional

Merged by Alexandre JulliardAlexandre Julliard 1 year ago (Apr 1, 2024 8:41pm UTC)

Merge details

  • Changes merged into master with 7f60584a.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading