Skip to content

Draft: Improve code readability in Widl.

Bernhard Kölbl requested to merge besentv/wine:merge2 into master

Currently, Widl's code formatting is in a very dissatisfying state, making in hard to dig through and work with it. For example, the used tabs have a width of 8, but some code areas then mix them with 4 or even just 2 space indents... Even worse, some code parts using just tabs aren't formatted properly in the first place. Making the code look like a minified JavaScript blob a bunch of times, which causes you to lose track of where you are often, and giving you a harder time to understand of what's going on:

image

This patch set is a draft on how this could be improved, using just space indents in the lexer file as an example. It surely isn't a great thing for version control (especially on Widl), but does in my opinion greatly improve the code use- and readability.

image

The improvement is even better when you take wrong tab sizes into account:

image

Excited about some opinions.

Signed-off-by: Bernhard Kölbl besentv@gmail.com

Merge request reports

Loading