Skip to content
Snippets Groups Projects

win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.

Merged Giovanni Mascellani requested to merge giomasce/wine:msgwnd into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=118684
      
      Your paranoid android.
      
      
      === w7u_adm (32 bit report) ===
      
      user32:
      win.c:1237: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0149017A fg 00050124 in hook HCBT_MINMAX
      
      === w1064 (32 bit report) ===
      
      user32:
      win.c:10890: Test failed: pos = 014a015e
      
      === w10pro64_ar (64 bit report) ===
      
      user32:
      win.c:4419: Test failed: message 0200 available
      win.c:4642: Test failed: hwnd 00000000000801FA/00000000000801FA message 0200
      win.c:4644: Test failed: wparam 0
      win.c:4655: Test failed: hwnd 00000000000801FA/00000000000801FA message 0203
      win.c:4659: Test failed: message 0202 available
  • added 20 commits

    • 0b4aa1e7...6e32c011 - 18 commits from branch wine:master
    • 6f970280 - user32/tests: Check that a message window brought topmost does not defocus other windows.
    • 3f963695 - win32u/window: Ignore SetWindowPos() for message-only windows.

    Compare with previous version

  • Giovanni Mascellani changed title from user32/tests: Check that a message window brought topmost does not defocus other windows. to win32u/window: Ignore SetWindowPos() for message-only windows.

    changed title from user32/tests: Check that a message window brought topmost does not defocus other windows. to win32u/window: Ignore SetWindowPos() for message-only windows.

  • Giovanni Mascellani changed the description

    changed the description

  • Giovanni Mascellani resolved all threads

    resolved all threads

    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=118754
      
      Your paranoid android.
      
      
      === w1064_adm (64 bit report) ===
      
      user32:
      win.c:2688: Test failed: style 0x200000: expected !100
      win.c:2688: Test failed: style 0x300000: expected !100
      
      === debian11 (32 bit report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Arabic:Morocco report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit German report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit French report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Hebrew:Israel report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Hindi:India report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Japanese:Japan report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Chinese:China report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit WoW report) ===
      
      user32:
      win.c:9332: Test failed: Expect width 100, got 1030.
      win.c:9333: Test failed: Expect height 100, got 743.
      win.c:8936: Test failed: Last error unexpectedly set to 0
      
      === debian11 (64 bit WoW report) ===
      
      user32:
      win.c:8936: Test failed: Last error unexpectedly set to 0
    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=118755
      
      Your paranoid android.
      
      
      === w10pro64 (32 bit report) ===
      
      user32:
      win.c:4558: Test failed: hwnd 00020266/00020266 message 0200
      win.c:4563: Test failed: hwnd 00020266/00020266 message 0203
      win.c:4567: Test failed: message 0202 available
      
      === w10pro64_en_AE_u8 (64 bit report) ===
      
      user32:
      win.c:4558: Test failed: hwnd 0000000000BA0324/0000000000BA0324 message 0200
      win.c:4563: Test failed: hwnd 0000000000BA0324/0000000000BA0324 message 0203
      win.c:4567: Test failed: message 0202 available
      
      === debian11 (32 bit report) ===
      
      user32:
      win.c:8906: Test failed: WM_KILLFOCUS message was delivered
      
      === debian11 (32 bit French report) ===
      
      user32:
      win.c:8906: Test failed: WM_KILLFOCUS message was delivered
      
      === debian11 (32 bit Hebrew:Israel report) ===
      
      user32:
      win.c:8906: Test failed: WM_KILLFOCUS message was delivered
      
      === debian11 (32 bit Chinese:China report) ===
      
      user32:
      win.c:8906: Test failed: WM_KILLFOCUS message was delivered
      
      === debian11 (32 bit WoW report) ===
      
      user32:
      win.c:8906: Test failed: WM_KILLFOCUS message was delivered
      
      === debian11 (64 bit WoW report) ===
      
      user32:
      win.c:8906: Test failed: WM_KILLFOCUS message was delivered
  • added 77 commits

    • 3f963695...7ff50883 - 75 commits from branch wine:master
    • 0ef8bac7 - user32/tests: Check that message-only windows ignore WS_EX_TOPMOST.
    • fcf10615 - win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.

    Compare with previous version

    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=119030
      
      Your paranoid android.
      
      
      === w10pro64_en_AE_u8 (64 bit report) ===
      
      user32:
      win.c:4400: Test failed: message 0200 available
      
      === debian11 (32 bit report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Arabic:Morocco report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit German report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit French report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Hebrew:Israel report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Hindi:India report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Japanese:Japan report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit Chinese:China report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (32 bit WoW report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
      
      === debian11 (64 bit WoW report) ===
      
      user32:
      win.c:8961: Test failed: Last error unexpectedly set to 0
    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=119031
      
      Your paranoid android.
      
      
      === w1064_tsign (64 bit report) ===
      
      user32:
      win.c:10918: Test failed: pos = 014a015e
      
      === debian11 (32 bit report) ===
      
      user32:
      win.c:8969: Test failed: Unexpected event was delivered
      
      === debian11 (32 bit German report) ===
      
      user32:
      win.c:8969: Test failed: Unexpected event was delivered
      
      === debian11 (32 bit Hindi:India report) ===
      
      user32:
      win.c:8969: Test failed: Unexpected event was delivered
      
      === debian11 (32 bit Japanese:Japan report) ===
      
      user32:
      win.c:8969: Test failed: Unexpected event was delivered
      
      === debian11 (32 bit WoW report) ===
      
      user32:
      win.c:8969: Test failed: Unexpected event was delivered
      
      === debian11 (64 bit WoW report) ===
      
      user32:
      win.c:8969: Test failed: Unexpected event was delivered
  • added 20 commits

    • fcf10615...a0febe90 - 18 commits from branch wine:master
    • 9188b8c8 - user32/tests: Check that message-only windows ignore WS_EX_TOPMOST.
    • eef72af6 - win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.

    Compare with previous version

  • Giovanni Mascellani resolved all threads

    resolved all threads

  • Giovanni Mascellani changed title from win32u/window: Ignore SetWindowPos() for message-only windows. to win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.

    changed title from win32u/window: Ignore SetWindowPos() for message-only windows. to win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.

    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=119087
      
      Your paranoid android.
      
      
      === w10pro64_ja (64 bit report) ===
      
      user32:
      win.c:4558: Test failed: hwnd 00000000000C032A/00000000000C032A message 0200
      win.c:4563: Test failed: hwnd 00000000000C032A/00000000000C032A message 0203
      win.c:4567: Test failed: message 0202 available
    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The tests also ran into some preexisting test failures. If you know how
      to fix them that would be helpful. See the TestBot job for the details:
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=119088
      
      Your paranoid android.
      
      
      === w10pro64_ja (64 bit report) ===
      
      user32:
      win.c:189: Test failed: didn't get start_event
      win.c:10399: Test failed: WindowFromPoint returned 0000000000020338, expected 0000000000000000
      win.c:10407: Test failed: WindowFromPoint returned 0000000000040336, expected 0000000000000000
      win.c:10336: Test failed: transparent window didn't get WM_NCHITTEST message
      
      === debian11 (32 bit report) ===
      
      user32:
      win.c:8992: Test failed: Unexpected event was delivered
      
      === debian11 (32 bit Hebrew:Israel report) ===
      
      user32:
      win.c:8992: Test failed: Unexpected event was delivered
      
      === debian11 (32 bit Hindi:India report) ===
      
      user32:
      win.c:8992: Test failed: Unexpected event was delivered
  • added 29 commits

    • eef72af6...dfff9217 - 27 commits from branch wine:master
    • 687b3e7f - user32/tests: Check that message-only windows ignore WS_EX_TOPMOST.
    • 78100b8b - win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.

    Compare with previous version

    • Contributor
      Resolved by Giovanni Mascellani

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=119241
      
      Your paranoid android.
      
      
      === w10pro64_ar (64 bit report) ===
      
      user32:
      win.c:4641: Test failed: hwnd 000000000005025C/000000000005025C message 0200
      win.c:4643: Test failed: wparam 0
      win.c:4654: Test failed: hwnd 000000000005025C/000000000005025C message 0203
      win.c:4658: Test failed: message 0202 available
      
      === w10pro64_ja (64 bit report) ===
      
      user32:
      win.c:10957: Test failed: msg.message = 1e
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading