Skip to content
Snippets Groups Projects

wineusb.sys: Fix memory leak on control transfer.

Closed Jinoh Kang requested to merge iamahuman/wine:wineusb.sys/memory-leak-fix into master
All threads resolved!

Signed-off-by: Jinoh Kang jinoh.kang.kr@gmail.com

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Contributor
      Resolved

      Zebediah Figura replied on the mailing list:

      On 7/9/22 11:10, Jinoh Kang wrote:
      > From: Jinoh Kang <jinoh.kang.kr@gmail.com>
      > 
      > Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com>
      > ---
      >   dlls/wineusb.sys/wineusb.c | 5 +++++
      >   1 file changed, 5 insertions(+)
      > 
      > diff --git a/dlls/wineusb.sys/wineusb.c b/dlls/wineusb.sys/wineusb.c
      > index 0b8af43a3dc..e1ec7d3d9bc 100644
      > --- a/dlls/wineusb.sys/wineusb.c
      > +++ b/dlls/wineusb.sys/wineusb.c
      > @@ -824,6 +824,11 @@ static void LIBUSB_CALL transfer_cb(struct libusb_transfer *transfer)
      >           }
      >       }
      >   
      > +    if (urb->UrbHeader.Function != URB_FUNCTION_BULK_OR_INTERRUPT_TRANSFER)
      > +    {
      > +        free(transfer->buffer);
      > +    }
      > +
      >       event.type = USB_EVENT_TRANSFER_COMPLETE;
      >       event.u.completed_irp = irp;
      >       queue_event(&event);
      
      We use LIBUSB_TRANSFER_FREE_TRANSFER for these cases.
      _______________________________________________
      wine-gitlab mailing list -- wine-gitlab@winehq.org
      To unsubscribe send an email to wine-gitlab-leave@winehq.org
  • closed

  • Jinoh Kang resolved all threads

    resolved all threads

Please register or sign in to reply
Loading