winmm: Avoid use of hardcoded return values.
All threads resolved!
All threads resolved!
Based on patch by Michael Müller.
Merge request reports
Activity
added 179 commits
-
26133fc8...ee17400c - 178 commits from branch
wine:master
- 9a5ee7b1 - winmm: Avoid use of hardcoded return values.
-
26133fc8...ee17400c - 178 commits from branch
What about If I changed the commit message to winmm: MCI_MapMsgAtoW return error code directly instead of a boolean.
That's my point: it doesn't currently return a boolean, it returns a tri-state. One of those values tells the caller to skip calling
MCI_UnmapMsgAtoW()
. Your change gets rid of this.added 499 commits
-
9a5ee7b1...0c7a09cb - 497 commits from branch
wine:master
- c81a118b - winmm: Always call MCI_UnmapMsgAtoW in mciSendCommandA.
- 3131a3d1 - winmm: MCI_MapMsgAtoW return error code directly instead of a tri-value.
-
9a5ee7b1...0c7a09cb - 497 commits from branch
added 119 commits
-
3131a3d1...d9ad68a1 - 117 commits from branch
wine:master
- 33b2c4b4 - winmm: Always call MCI_UnmapMsgAtoW in mciSendCommandA.
- 0d976003 - winmm: MCI_MapMsgAtoW return error code directly instead of a tri-value.
-
3131a3d1...d9ad68a1 - 117 commits from branch
added 390 commits
-
0d976003...01d7780a - 388 commits from branch
wine:master
- d284e7f4 - winmm: Always call MCI_UnmapMsgAtoW in mciSendCommandA.
- 88a7db01 - winmm: MCI_MapMsgAtoW return error code directly instead of a tri-value.
-
0d976003...01d7780a - 388 commits from branch
- Resolved by Alistair Leslie-Hughes
added 57 commits
-
88a7db01...99aa613f - 55 commits from branch
wine:master
- dda7f628 - winmm: Always call MCI_UnmapMsgAtoW in mciSendCommandA.
- c335ae34 - winmm: MCI_MapMsgAtoW return error code directly instead of a tri-value.
-
88a7db01...99aa613f - 55 commits from branch
Please register or sign in to reply