Skip to content
Snippets Groups Projects

user32: Ignore invalid parameters in DrawTextEx when HDC is invalid

Merged Fabian Maurer requested to merge DarkShadow44/wine:draw_text into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Contributor
      Resolved by Fabian Maurer

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The tests also ran into some preexisting test failures. If you know how
      to fix them that would be helpful. See the TestBot job for the details:
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=133703
      
      Your paranoid android.
      
      
      === w7u_2qxl (32 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0748:text: unhandled exception c0000005 at 77D9312E
      
      === w7u_adm (32 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0864:text: unhandled exception c0000005 at 7795312E
      
      === w7u_el (32 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0344:text: unhandled exception c0000005 at 7739312E
      
      === w8 (32 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0adc:text: unhandled exception c0000005 at 76F4A95F
      
      === w8adm (32 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0ad0:text: unhandled exception c0000005 at 776CA95F
      
      === w864 (32 bit report) ===
      
      user32:
      0b6c:text: unhandled exception c0000005 at 77A8470C
      
      === w1064v1507 (32 bit report) ===
      
      user32:
      0ca0:text: unhandled exception c0000005 at 7738111C
      
      === w1064v1809 (32 bit report) ===
      
      user32:
      1dbc:text: unhandled exception c0000005 at 77E9105B
      
      === w1064_tsign (32 bit report) ===
      
      user32:
      1e4c:text: unhandled exception c0000005 at 77BB200C
      
      === w10pro64 (32 bit report) ===
      
      user32:
      1c9c:text: unhandled exception c0000005 at 77021ECC
      
      === w11pro64 (32 bit report) ===
      
      user32:
      1e54:text: unhandled exception c0000005 at 770F8495
      
      === w7pro64 (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0ac4:text: unhandled exception c0000005 at 0000000076FDF1EF
      
      === w864 (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      054c:text: unhandled exception c0000005 at 00007FFDCF49071F
      
      === w1064v1507 (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0e54:text: unhandled exception c0000005 at 00007FFD62533A26
      
      === w1064v1809 (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      1804:text: unhandled exception c0000005 at 00007FFB7E495D45
      
      === w1064_2qxl (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0a04:text: unhandled exception c0000005 at 00007FF8B923EBD7
      
      === w1064_adm (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      1d94:text: unhandled exception c0000005 at 00007FFFA49BEBD7
      
      === w1064_tsign (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      1d9c:text: unhandled exception c0000005 at 00007FF8F631EBD7
      
      === w10pro64 (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      20e8:text: unhandled exception c0000005 at 00007FFF2EE7EB87
      
      === w10pro64_en_AE_u8 (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      22ac:text: unhandled exception c0000005 at 00007FFA74CC94CC
      
      === w10pro64_ar (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0640:text: unhandled exception c0000005 at 00007FFA0991EB87
      
      === w10pro64_ja (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0c20:text: unhandled exception c0000005 at 00007FF96EADE7B0
      
      === w10pro64_zh_CN (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      0ca4:text: unhandled exception c0000005 at 00007FF8B574E7B0
      
      === w11pro64_amd (64 bit report) ===
      
      user32:
      text.c:533: Test failed: Got error 6
      23f4:text: unhandled exception c0000005 at 00007FF99E0EE276
  • Fabian Maurer added 1 commit

    added 1 commit

    • 796c81ed - user32: Ignore invalid parameters in DrawTextEx when HDC is invalid

    Compare with previous version

  • Fabian Maurer resolved all threads

    resolved all threads

  • Fabian Maurer added 1 commit

    added 1 commit

    • 562010f7 - user32: Ignore invalid parameters in DrawTextEx when HDC is invalid

    Compare with previous version

    • Contributor
      Resolved by Fabian Maurer

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The tests also ran into some preexisting test failures. If you know how
      to fix them that would be helpful. See the TestBot job for the details:
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=133708
      
      Your paranoid android.
      
      
      === debian11 (32 bit report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032abd).
      
      === debian11 (32 bit ar:MA report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032abd).
      
      === debian11 (32 bit de report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032abd).
      
      === debian11 (32 bit fr report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032abd).
      
      === debian11 (32 bit he:IL report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032abd).
      
      === debian11 (32 bit hi:IN report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7bc3a389).
      
      === debian11 (32 bit ja:JP report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032c40).
      
      === debian11 (32 bit zh:CN report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032c40).
      
      === debian11b (32 bit WoW report) ===
      
      user32:
      Unhandled exception: page fault on read access to 0x00636000 in 32-bit code (0x7b032abd).
  • Fabian Maurer resolved all threads

    resolved all threads

  • Author Contributor

    Any new on this?

  • Alexandre Julliard added 492 commits

    added 492 commits

    • 562010f7...9f9f799a - 491 commits from branch wine:master
    • 35c8f15b - user32: Ignore invalid parameters in DrawTextEx when HDC is invalid.

    Compare with previous version

  • Alexandre Julliard approved this merge request

    approved this merge request

  • This introduces a new test failure on Windows as predicted by the TestBot: https://bugs.winehq.org/show_bug.cgi?id=55215

Please register or sign in to reply
Loading