mmdevapi: Rename mmdevapi.h to mmdevapi_private.h, add missing includes and typedef to that and mmdevdrv.h.
This should make it clear it's not an external header.
It could be confused with mmdeviceapi.h
, in particular.
Merge request reports
Activity
mentioned in merge request !2636 (merged)
18 18 19 19 #include "unixlib.h" My preferred order would be like this:
- Local
- Standard
- Other
An advantage of including the local headers first is that it ensures they're complete (i.e. include everything their content requires).
However, consistency could definitely be considered more important. On that note, should I also adhere to the quotes vs angle brackets convention in this MR?
changed this line in version 2 of the diff
- Resolved by Davide Beatrici
I should have asked this earlier, but do we need a separate
mmdevdrv.h
, or could that go inmmdevapi_private.h
?We could indeed merge the first into the latter once no drivers include it anymore.
removed review request for @aeikum
added 39 commits
-
65bbc75c...20be5ecd - 36 commits from branch
wine:master
- f7dfba08 - mmdevapi: Rename mmdevapi.h to mmdevapi_private.h.
- 6cfc3740 - mmdevapi: Add missing includes to mmdevapi_private.h.
- 27d88669 - mmdevapi: Add missing includes and typedef to mmdevdrv.h.
Toggle commit list-
65bbc75c...20be5ecd - 36 commits from branch