Skip to content
Snippets Groups Projects

comctl32/listview: Reset the value of bNoItemMetrics in LISTVIEW_DeleteAllItems().

Closed Zhao Yi requested to merge Zhaoyi/wine:master into master
4 unresolved threads

Reset the valuse of bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems() to Fix "2345 picture viewer" not displaying all files.

Signed-off-by: Zhao Yi zhaoyi@uniontech.com

Edited by Zhao Yi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Author Contributor

      Update commit message.

    • The commit message in the actual commit also needs to be updated, not just the message for this merge request. You can update the commit message by using "git commit --amend", and then force push to the same branch. You don't need to close the old merge request and open a new one.

    • Please register or sign in to reply
  • Ghost User requested review from @nsivov and @zhiyi

    requested review from @nsivov and @zhiyi

  • Zhao Yi added 66 commits

    added 66 commits

    • 14a95434 - wined3d: Don't bother explicitly terminating the GLSL info log in print_glsl_info_log().
    • b4e94d56 - wined3d: Use wined3d_get_line() in shader_glsl_compile().
    • 464e07ba - wined3d: Use wined3d_get_line() in shader_glsl_dump_program_source().
    • aa75bf28 - wined3d: Use wined3d_get_line() in shader_arb_compile().
    • c06627ce - wined3d: Use wined3d_get_line() in shader_spirv_compile_shader().
    • 8700ae7d - wined3d: Use wined3d_get_line() in shader_spirv_scan_shader().
    • 6a501050 - wined3d: Move the WINED3D_RS_WRAP2 stub to wined3d_device_apply_stateblock.
    • cef18ea8 - wined3d: Move the WINED3D_RS_WRAP1 stub to wined3d_device_apply_stateblock.
    • 1d2da4c0 - wined3d: Move the WINED3D_RS_WRAP0 stub to wined3d_device_apply_stateblock.
    • bcc3eb43 - wined3d: Move the WINED3D_RS_EXTENTS stub to wined3d_device_apply_stateblock.
    • 53201007 - wined3d: Move the WINED3D_RS_COLORKEYBLENDENABLE stub to wined3d_device_apply_stateblock.
    • 46312a7b - ddraw: Rename "is_complex_root" to "is_root".
    • f55cb044 - ddraw: Remove some outdated comments from ddraw_surface7_SetSurfaceDesc().
    • e213efbf - ddraw: Move sysmem_fallback setting to ddraw_surface_create_wined3d_texture().
    • c5011354 - ddraw: Factor out more common initialization into ddraw_surface_create_wined3d_texture().
    • ad18931d - ddraw: Move sub-resource surface initialization to ddraw_surface_create_wined3d_texture().
    • e6196501 - imm32: Implement ImmLoadIME and ImmFreeLayout.
    • ecd96916 - imm32: Rename some struct ime members.
    • 5eefe433 - imm32: Delete unnecessary uSelected struct ime member.
    • 01eaacd1 - imm32: Use a single ime_is_unicode helper.
    • be29d39c - ntdll: Fix some CPU information tests on ARM64.
    • aa8bd1e7 - ntdll: Implement the SystemProcessorBrandString query.
    • b2cd55d1 - ntdll: Implement the SystemProcessorFeaturesInformation query.
    • 6d98d7f4 - wineboot: Use the SystemProcessorBrandString query instead of cpuid.
    • bb4a484b - d3d11: Get rid of the DXBC tag definitions.
    • 75995ea6 - wined3d: Sort the exports.
    • c95317e1 - d3d8/tests: Remove an unused call to IDirect3D8_GetAdapterDisplayMode().
    • c9df6714 - mfplat/tests: Test bytestream closing behavior in IMFMediaSource::Shutdown.
    • fb513df4 - winegstreamer/media_source: Close bytestream in ::Shutdown.
    • f5246665 - win32u: Keep the current user locale when enumerating layouts.
    • 423fb917 - win32u: Keep the current user locale when loading layout.
    • d91cd1d9 - win32u: Prevent user locale change in NtUserActivateKeyboardLayout.
    • 2e5b98d6 - winex11: Remove now unnecessary user locale change checks.
    • 0f6167f8 - wintypes: Stub RoIsApiContractMajorVersionPresent().
    • 3cc97582 - wofutil: Stub WofIsExternalFile().
    • 58afb6da - windows.networking: Stub DllGetActivationFactory().
    • 193045b4 - widl: Use explicit %empty token for empty rules.
    • 451be884 - widl: Add missing rule end semicolons.
    • 2e81c1d8 - widl: Use noyywrap lexer option.
    • 0890f524 - widl: Use bison-bridge option.
    • f0b53d63 - widl: Remove unused temp_name member.
    • 4cae505e - d3dcompiler: Handle some newer D3D_BLOB_PART values in debug_d3dcompiler_d3d_blob_part().
    • cc106a65 - ntdll/tests: Handle another possible status when...
    • 2c754956 - ntdll/tests: Fix Wow64 tests failures on Windows 11 ARM64.
    • a7d12634 - ntdll/tests: Update some todos that succeed with the new wow64 architecture.
    • 6ef7439c - ntdll: Implement NtWow64IsProcessorFeaturePresent().
    • b0396e6d - wow64: Forward NtWow64IsProcessorFeaturePresent() to the CPU backend.
    • 29278375 - wineboot: Add processor features for supported WoW64 architectures on ARM64.
    • ceb4cae0 - imm32: Rename szImeRegFmt to layouts_formatW.
    • 2546b7c0 - imm32: Transform "Ime File" value in ImmInstallIMEW.
    • 54860a7e - imm32: Rewrite ImmGetIMEFileName(A|W).
    • 5e13c32a - imm32: Rewrite ImmGetDescription(A|W).
    • 1daf03c7 - imm32: Use CRT allocation functions.
    • 3cd12481 - kernelbase: Pass the root key to open_key().
    • 96c96b1f - kernelbase: Pass the key name to open_key().
    • c25e85fc - kernelbase: Pass the root key to create_key().
    • 1495cd9d - kernelbase: Pass the key name to create_key().
    • d35f5173 - kernelbase: Restructure the open_key() loop.
    • b5c796fa - kernelbase: Always try to open the Wow6432Node in open_key().
    • dfb5a16c - kernelbase: Factor opening a subkey out of open_key().
    • 89bea207 - kernelbase: Move create_key() below open_key().
    • 84333ec5 - kernelbase: Add a fast path to create_key().
    • 86183487 - kernelbase: Restructure the create_key() loop.
    • 5ea23a1d - gitlab: Make FVWM respect position hints.
    • 8ff66d51 - user32/tests: Do not modify cursor position when simulating clicks.
    • f2b985e1 - light.msstyles: Add nonclient metrics.

    Compare with previous version

  • Please rebase the branch on wine master. Your commit is in the middle of wine upstream commits. You can use "git fetch origin && git rebase origin/master"

  • Zhao Yi added 67 commits

    added 67 commits

    • f2b985e1...81976e5c - 66 commits from branch wine:master
    • 06cfd84c - comctl32: Fix the problem that listview cannot display all files.

    Compare with previous version

    • Contributor

      Marvin replied on the mailing list:

      Hi,
      
      It looks like your patch introduced the new failures shown below.
      Please investigate and fix them before resubmitting your patch.
      If they are not new, fixing them anyway would help a lot. Otherwise
      please ask for the known failures list to be updated.
      
      The tests also ran into some preexisting test failures. If you know how
      to fix them that would be helpful. See the TestBot job for the details:
      
      The full results can be found at:
      https://testbot.winehq.org/JobDetails.pl?Key=130645
      
      Your paranoid android.
      
      
      === debian11 (32 bit report) ===
      
      dinput:
      device8.c:432: Test failed: 0x800: WaitForSingleObject returned 0x102
      device8.c:437: Test failed: 0x800: got count 0
      device8.c:452: Test failed: 0x800: WaitForSingleObject returned 0x102
      device8.c:457: Test failed: 0x800: got count 0
    • In general, we try to be specific about the commit message subject instead of just saying "fix something". You can say "comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems()." in the commit message subject and then in the commit message body "Fix 2345 picture viewer not displaying all files."

      Edited by Zhiyi Zhang
    • Author Contributor

      OK, I will modify the commit message as you said later ^V^.

    • Author Contributor

      I have just updated my commit message and you can review it again.

    • Please register or sign in to reply
  • Zhao Yi added 54 commits

    added 54 commits

    • 06cfd84c...446da60e - 53 commits from branch wine:master
    • 4c0e8e86 - comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().

    Compare with previous version

  • Zhiyi Zhang approved this merge request

    approved this merge request

    • For commit message it's better to have some description message, and not duplicating what code actually does.

    • Author Contributor

      I have just updated my commit message and you can review it again.

    • Again, MR description is what it should look like. What you have for commit message duplicates code changes. New paragraph in commit message mixes together unrelated things - it's talking about shellview case it seems, which is not something Listview is directly related to.

    • Please register or sign in to reply
  • Zhao Yi added 156 commits

    added 156 commits

    • 4c0e8e86...3149d272 - 155 commits from branch wine:master
    • 84e50868 - comctl32/listview: Set bNoItemMetrics to TRUE in LISTVIEW_DeleteAllItems().

    Compare with previous version

  • Zhao Yi added 1796 commits

    added 1796 commits

    • 84e50868...c47c4d54 - 1795 commits from branch wine:master
    • fbbdcaa5 - comctl32/listview: Reset the value of bNoItemMetrics in LISTVIEW_DeleteAllItems().

    Compare with previous version

  • Author Contributor

    update commit message.

  • Zhao Yi added 1 commit

    added 1 commit

    • 26b26161 - comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.

    Compare with previous version

  • Zhao Yi changed title from comctl32: Fix the problem that listview cannot display all files. to comctl32/listview: Reset the value of bNoItemMetrics in LISTVIEW_DeleteAllItems().

    changed title from comctl32: Fix the problem that listview cannot display all files. to comctl32/listview: Reset the value of bNoItemMetrics in LISTVIEW_DeleteAllItems().

  • Zhao Yi changed the description

    changed the description

  • closed

  • reopened

  • Zhao Yi added 1 commit

    added 1 commit

    • 03aee987 - comctl32: Make the correct linkid from fun SYSLINK_LinkAtPt.

    Compare with previous version

  • closed

Please register or sign in to reply
Loading