Skip to content
Snippets Groups Projects

tests/shader-runner: Create a new runner object for the shader model 6 tests.

Merged Conor McCarthy requested to merge cmccarthy/vkd3d:runner_sm6 into master
3 unresolved threads

If cleaning up the old runner is not completed, descriptors for destroyed resources may remain on the heap.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
856 855 ID3D12DescriptorHeap_Release(runner.dsv_heap);
857 856 destroy_test_context(&runner.test_context);
858 857 }
858
859 void run_shader_tests_d3d12(void *dxc_compiler)
860 {
861 run_shader_tests_for_model_range(NULL, SHADER_MODEL_4_0, SHADER_MODEL_5_1);
862
863 if (dxc_compiler)
864 run_shader_tests_for_model_range(dxc_compiler, SHADER_MODEL_6_0, SHADER_MODEL_6_0);
865 }
    • I don't have a particular problem with your solution, and some aspects of it are arguably even cleaner than before, but couldn't we just clean up descriptor heaps before running tests again?

    • In the absence of a compelling reason to do it that way, it's neater and less fragile to create a new object each time.

    • Please register or sign in to reply
  • Giovanni Mascellani
    Giovanni Mascellani @giomasce started a thread on an outdated change in commit 37d85625
  • 816 818 init_adapter_info();
  • added 1 commit

    • e63a75d5 - tests/shader-runner: Create a new runner object for the shader model 6 tests.

    Compare with previous version

  • Conor McCarthy changed title from tests/shader-runner: Create a new runner for the shader model 6 tests. to tests/shader-runner: Create a new runner object for the shader model 6 tests.

    changed title from tests/shader-runner: Create a new runner for the shader model 6 tests. to tests/shader-runner: Create a new runner object for the shader model 6 tests.

  • Giovanni Mascellani approved this merge request

    approved this merge request

  • Henri Verbeet approved this merge request

    approved this merge request

  • Henri Verbeet added 32 commits

    added 32 commits

    • e63a75d5...7534b88a - 31 commits from branch wine:master
    • da1d96f7 - tests/shader-runner: Create a new runner object for the shader model 6 tests.

    Compare with previous version

  • Please register or sign in to reply
    Loading