vkd3d-shader/hlsl: Improve mul vs dp* selection for dot().
1 unresolved thread
1 unresolved thread
Merge request reports
Activity
1636 1636 return NULL; 1637 1637 } 1638 1638 1639 if (arg1->data_type->type == HLSL_CLASS_SCALAR) 1640 dim = arg2->data_type->dimx; 1641 else if (arg1->data_type->type == HLSL_CLASS_SCALAR) 1642 dim = arg1->data_type->dimx; 1643 else 1639 if (arg1->data_type->type == HLSL_CLASS_SCALAR && arg2->data_type->type == HLSL_CLASS_SCALAR) 1640 dim = 1; 1641 else if (arg1->data_type->type == HLSL_CLASS_VECTOR && arg2->data_type->type == HLSL_CLASS_VECTOR) 1644 1642 dim = min(arg1->data_type->dimx, arg2->data_type->dimx); 1643 else 1644 dim = max(arg1->data_type->dimx, arg2->data_type->dimx); - Comment on lines -1639 to +1644
The change itself looks fine, if a tad complicated (it would have been enough to change one character: from
else if (arg1->data_type->type == HLSL_CLASS_SCALAR)
toelse if (arg2->data_type->type == HLSL_CLASS_SCALAR)
).Though it's easy to write a test that shows that this fixes a bug, so I think there should be one.
changed this line in version 2 of the diff
added 14 commits
-
84114e5a...0e60f4cc - 13 commits from branch
wine:master
- 0aad732a - vkd3d-shader/hlsl: Use mul only for two scalars for dot().
-
84114e5a...0e60f4cc - 13 commits from branch
requested review from @giomasce
removed review request for @giomasce
added 1 commit
- 99acf503 - vkd3d-shader/hlsl: Use mul only for two scalars for dot().
Please register or sign in to reply