include: Add missing constants in vkd3d_d3d12.idl
Merge request reports
Activity
Somewhat like patch 3/3 in the other MR, could you try to split patch 3/3 a little? E.g., common shader constants, compute shader constants, domains shader constants, and so on. We'll probably still end up with a bunch of "miscellaneous" constants at the end, but hopefully few enough of them that it's not much of an issue.
I definitely see the need of splitting, but I find this one harder (or simply, much more effort) to split in any meaningful way as I'm not very familiar with their actual use.
I'd suggest something like this:
- D3D12_COMMONSHADER_*; Common shader constants.
- D3D12_CS_*; Compute shader constants.
- D3D12_DS_*; Domain shader constants.
- D3D12_GS_*; Geometry shader constants.
- D3D12_HS_*; Hull shader constants.
- D3D12_IA_*; Input Assembler constants.
- D3D12_PS_*; Pixel shader constants.
- D3D12_RAYTRACING_*; Ray-tracing constants.
- D3D12_REQ_*; Minimum resource limit constants.
- D3D12_VS_*; Vertex shader constants.
- Miscellaneous constants.
That probably leaves "Miscellaneous constants" a bit larger than it strictly needs to be, but small enough that I'm not too bothered about it.
added 13 commits
- f500721a...93f4e53c - 3 earlier commits
- 15375649 - include: Add missing D3D12 compute shader constants.
- 95a2e0e6 - include: Add missing D3D12 domain shader constants.
- 9fd789d6 - include: Add missing D3D12 geometry shader constants.
- 57af6451 - include: Add missing D3D12 hull shader constants.
- 8379481a - include: Add missing D3D12 input assembler constants.
- ecf0b85d - include: Add missing D3D12 pixel shader constants.
- 56b23ae6 - include: Add missing D3D12 raytracing constants.
- f02a0101 - include: Add missing D3D12 minimum resource limit constants.
- 5481083d - include: Add missing D3D12 vertex shader constants.
- e712411e - include: Add missing miscellaneous D3D12 constants.
Toggle commit listLowercased those now, thanks!
Edited by Martin Storsjö
added 17 commits
-
e712411e...f525e9e9 - 4 commits from branch
wine:master
- f525e9e9...276e4f2e - 3 earlier commits
- e9d4729f - include: Add missing D3D12 compute shader constants.
- 4d8d80f3 - include: Add missing D3D12 domain shader constants.
- 6fe38f40 - include: Add missing D3D12 geometry shader constants.
- 10fa6b92 - include: Add missing D3D12 hull shader constants.
- e022f0e6 - include: Add missing D3D12 input assembler constants.
- 4bb1cd89 - include: Add missing D3D12 pixel shader constants.
- ec9b1f10 - include: Add missing D3D12 raytracing constants.
- 03ef9a92 - include: Add missing D3D12 minimum resource limit constants.
- 0dfe373c - include: Add missing D3D12 vertex shader constants.
- 16decea5 - include: Add missing miscellaneous D3D12 constants.
Toggle commit list-
e712411e...f525e9e9 - 4 commits from branch
added 14 commits
-
c5d680d1 - 1 commit from branch
wine:master
- c5d680d1...71dd9170 - 3 earlier commits
- cf61d217 - include: Add missing D3D12 compute shader constants.
- af440314 - include: Add missing D3D12 domain shader constants.
- 1d74dc79 - include: Add missing D3D12 geometry shader constants.
- f8c848f5 - include: Add missing D3D12 hull shader constants.
- ef8dd51c - include: Add missing D3D12 input assembler constants.
- b32b0605 - include: Add missing D3D12 pixel shader constants.
- 7efba298 - include: Add missing D3D12 raytracing constants.
- 44a669a6 - include: Add missing D3D12 minimum resource limit constants.
- 61c40240 - include: Add missing D3D12 vertex shader constants.
- 1b45052c - include: Add missing miscellaneous D3D12 constants.
Toggle commit list-
c5d680d1 - 1 commit from branch
mentioned in merge request !235 (closed)