Skip to content
Snippets Groups Projects

Draft: tests: Make ddxddy.shader_test pass for different GPUs.

Closed Francisco Casas requested to merge fcasas/vkd3d:ddxddy_adjust into master
1 unresolved thread

On my Nvidia GeForce GTX 1050 Ti this test is not passing because of considerably different numeric results.

As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy().

Testing both ddx_coarse()|ddy_coarse() and ddx_fine()|ddy_fine() on the WARP driver shows that both these derivates are the same in coordinates where both X and Y are even, i.e. the first pixel of each 2x2 quad. So the test was modified to only probe on these coordinates.

The new expected values were obtained from running the test using the WARP driver, and ulps adjusted for my GPU. However, this MR is marked as a draft because I would like to know if the test passes on other GPUs.

Merge request reports

Approval is optional

Closed by Francisco CasasFrancisco Casas 1 year ago (Jun 5, 2023 9:42pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading