vkd3d-shader/hlsl: Improve handling of builtin aliases "matrix" and "vector".
Merge request reports
Activity
added 1 commit
- 0209f51f - vkd3d-shader/hlsl: Improve handling of builtin alias type "vector".
Unless I'm getting confused somehow, it seems that the tests introduced in 2/2 already pass in 1/2, so they don't really justify the changes in 2/2. More in general, I think it would be useful to first add the failing tests with todo and then, in a separated commit, add the code changes that fix the tests. That makes it easier for the reviewer to see why the commit is useful.
Unless I'm getting confused somehow, it seems that the tests introduced in 2/2 already pass in 1/2, so they don't really justify the changes in 2/2. More in general, I think it would be useful to first add the failing tests with todo and then, in a separated commit, add the code changes that fix the tests. That makes it easier for the reviewer to see why the commit is useful.
In general, yes, although this series is simple enough it's probably not worth rerolling.
added 39 commits
-
0209f51f...54b0165e - 37 commits from branch
wine:master
- 6e8f8433 - vkd3d-shader/hlsl: Improve handling of builtin alias type "matrix".
- 4acef3c2 - vkd3d-shader/hlsl: Improve handling of builtin alias type "vector".
-
0209f51f...54b0165e - 37 commits from branch
added 7 commits
-
4acef3c2...c61f9f47 - 5 commits from branch
wine:master
- 5b5c020a - vkd3d-shader/hlsl: Improve handling of builtin alias type "matrix".
- b172f4c2 - vkd3d-shader/hlsl: Improve handling of builtin alias type "vector".
-
4acef3c2...c61f9f47 - 5 commits from branch