Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
wine
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Sebastian Mayr
wine
Commits
ace95ca0
Commit
ace95ca0
authored
21 years ago
by
Dimitrie O. Paun
Committed by
Alexandre Julliard
21 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Small cleanups on how to send in patches.
parent
62dcebaa
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
documentation/patches.sgml
+12
-16
12 additions, 16 deletions
documentation/patches.sgml
with
12 additions
and
16 deletions
documentation/patches.sgml
+
12
−
16
View file @
ace95ca0
<chapter id="patches">
<title>Submitting Patches</title>
<para>
Written by &name-albert-den-haan; <email>&email-albert-den-haan;</email>
</para>
<sect1 id="patch-format">
<title>Patch Format</title>
<para>
Your patch should include:
Patches are submitted via email to the Wine patches mailing list,
<email>wine-patches@winehq.org</email>. Your patch should include:
</para>
<itemizedlist>
...
...
@@ -20,26 +18,25 @@
<listitem>
<para>
A long (paragraph) description of what was wrong and what is now
better
(and now broken :)
. (recommended)
better. (recommended)
</para>
</listitem>
<listitem>
<para>
C
hange
L
og
: A
short description of what was changed.
A c
hange
l
og
entry (
short description of what was changed
)
.
</para>
</listitem>
<listitem>
<para>
Your contact information ( Name/Handle and e-mail )
</para>
</listitem>
<listitem>
<para>
The patch in <command>diff -u</command> format (it happens...)
The patch in <command>diff -u</command> format
</para>
</listitem>
</itemizedlist>
<para>
</para>
<para>
<command>cvs diff -u</command> works great for the common case
where a file is edited. However, if you add or remove a file
...
...
@@ -47,15 +44,14 @@
make sure you explicitly take care of this rare case.
</para>
<para>
For additions: mention that you have some new files and
include them by appending the
For additions simply include them by appending the
<command>diff -u /dev/null /my/new/file</command> output of them
to any <command>cvs diff -u</command> output you may have.
Alternatively, use <command>diff -Nu olddir/ newdir/</command>
in case of multiple new files to add.
</para>
<para>
For removals, list the files.
For removals,
clearly
list the files
in the description of the patch
.
</para>
<para>
Since wine is constantly changing due to development it is strongly
...
...
@@ -182,7 +178,7 @@ code
<para>
<quote>The basic rules are: no attachments, no mime crap, no
line wrapping, a single patch per mail. Basically if I can't
do <
C
ommand>"cat raw_mail | patch -p0"</command> it's in the
do <
c
ommand>"cat raw_mail | patch -p0"</command> it's in the
wrong format.</quote>
</para>
</sect2>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment