Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
wine
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Package registry
Container registry
Model registry
Operate
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Lorenzo Ferrillo
wine
Commits
7025db43
Commit
7025db43
authored
13 years ago
by
Alistair Leslie-Hughes
Committed by
Alexandre Julliard
13 years ago
Browse files
Options
Downloads
Patches
Plain Diff
rasapi32: Return error on invalid parameters.
parent
33736bb8
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
dlls/rasapi32/rasapi.c
+4
-0
4 additions, 0 deletions
dlls/rasapi32/rasapi.c
dlls/rasapi32/tests/rasapi.c
+0
-4
0 additions, 4 deletions
dlls/rasapi32/tests/rasapi.c
with
4 additions
and
4 deletions
dlls/rasapi32/rasapi.c
+
4
−
0
View file @
7025db43
...
...
@@ -250,6 +250,10 @@ DWORD WINAPI RasEnumDevicesA(LPRASDEVINFOA lpRasDevinfo, LPDWORD lpcb, LPDWORD l
return
ERROR_INVALID_PARAMETER
;
FIXME
(
"(%p,%p,%p),stub!
\n
"
,
lpRasDevinfo
,
lpcb
,
lpcDevices
);
if
(
lpRasDevinfo
&&
lpRasDevinfo
->
dwSize
!=
sizeof
(
RASDEVINFOA
))
return
ERROR_INVALID_SIZE
;
if
(
!
lpRasDevinfo
||
(
*
lpcb
<
sizeof
(
RASDEVINFOA
)))
{
*
lpcb
=
sizeof
(
RASDEVINFOA
);
return
ERROR_BUFFER_TOO_SMALL
;
...
...
This diff is collapsed.
Click to expand it.
dlls/rasapi32/tests/rasapi.c
+
0
−
4
View file @
7025db43
...
...
@@ -85,7 +85,6 @@ static void test_rasenum(void)
rasDevInfo
[
0
].
dwSize
=
0
;
cb
=
bufsize
;
result
=
pRasEnumDevicesA
(
rasDevInfo
,
&
cb
,
&
cDevices
);
todo_wine
ok
(
result
==
ERROR_INVALID_SIZE
||
result
==
ERROR_INVALID_USER_BUFFER
,
/* win98 */
"Expected ERROR_INVALID_SIZE, got %08d
\n
"
,
result
);
...
...
@@ -93,7 +92,6 @@ static void test_rasenum(void)
rasDevInfo
[
0
].
dwSize
=
sizeof
(
RASDEVINFOA
)
-
1
;
cb
=
bufsize
;
result
=
pRasEnumDevicesA
(
rasDevInfo
,
&
cb
,
&
cDevices
);
todo_wine
ok
(
result
==
ERROR_INVALID_SIZE
||
result
==
ERROR_INVALID_USER_BUFFER
,
/* win98 */
"Expected ERROR_INVALID_SIZE, got %08d
\n
"
,
result
);
...
...
@@ -101,7 +99,6 @@ static void test_rasenum(void)
rasDevInfo
[
0
].
dwSize
=
sizeof
(
RASDEVINFOA
)
+
1
;
cb
=
bufsize
;
result
=
pRasEnumDevicesA
(
rasDevInfo
,
&
cb
,
&
cDevices
);
todo_wine
ok
(
result
==
ERROR_INVALID_SIZE
||
result
==
ERROR_INVALID_USER_BUFFER
,
/* win98 */
"Expected ERROR_INVALID_SIZE, got %08d
\n
"
,
result
);
...
...
@@ -151,7 +148,6 @@ static void test_rasenum(void)
cb
=
0
;
rasDevInfo
[
0
].
dwSize
=
0
;
result
=
pRasEnumDevicesA
(
rasDevInfo
,
&
cb
,
&
cDevices
);
todo_wine
ok
(
result
==
ERROR_INVALID_SIZE
||
broken
(
result
==
ERROR_BUFFER_TOO_SMALL
),
/* win98 */
"Expected ERROR_INVALID_SIZE, got %08d
\n
"
,
result
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment