Skip to content
Snippets Groups Projects
  1. Jul 25, 2023
    • Fotios Valasiadis's avatar
      Revert "server: Avoid using SOL_IPX to detect whether IPX is supported." · 755ab566
      Fotios Valasiadis authored
      This reverts commit 41cc117b.
      
      This commit broke musl support.
      
      With the changes introduced, the following code evaluates
      to the #else branch without checking for SO_DEFAULT_HEADERS
      resulting in an error.
      
      server/sock.c +1888
      ```
      \#ifdef HAS_IPX
              int ipx_type = protocol - WS_NSPROTO_IPX;
      \#ifdef SOL_IPX
              setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) );
      \#else
              struct ipx val;
              /* Should we retrieve val using a getsockopt call and then
               * set the modified one? */
              val.ipx_pt = ipx_type;
              setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) );
      \#endif
      \#endif
      ```
      
      I propose reverting the commit, but we could probably alter
      the macro in the code section provided to match the changes
      
      relevant github issue:
      https://github.com/void-linux/void-packages/pull/45202
      
      
      
      Signed-off-by: default avatarFotios Valasiadis <fvalasiad@gmail.com>
      755ab566
  2. Jul 24, 2023
Loading