Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
wine
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Li Wenzhe
wine
Commits
1ab8907f
Commit
1ab8907f
authored
25 years ago
by
Marcus Meissner
Committed by
Alexandre Julliard
25 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fixed ambigous else/brace problem, moved "name" computation in
CreateProcess _before_ outputting it in the FIXME_()s.
parent
b8830034
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
loader/module.c
+21
-21
21 additions, 21 deletions
loader/module.c
with
21 additions
and
21 deletions
loader/module.c
+
21
−
21
View file @
1ab8907f
...
...
@@ -1028,14 +1028,15 @@ static BOOL make_lpCommandLine_name( LPCSTR line, LPSTR name, int namelen,
}
while
(
1
);
/* if we have a non-null full path name in buffer then move to output */
if
(
retlen
)
if
(
strlen
(
buffer
)
<=
namelen
)
if
(
retlen
)
{
if
(
strlen
(
buffer
)
<=
namelen
)
{
strcpy
(
name
,
buffer
);
else
{
}
else
{
/* not enough space to return full path string */
FIXME_
(
module
)(
"internal string not long enough, need %d
\n
"
,
strlen
(
buffer
)
);
}
}
/* all done, indicate end of module name and then trace and exit */
if
(
after
)
*
after
=
from
;
...
...
@@ -1139,6 +1140,23 @@ BOOL WINAPI CreateProcessA( LPCSTR lpApplicationName, LPSTR lpCommandLine,
return
FALSE
;
}
/* Process the AppName or CmdLine to get module name and path */
name
[
0
]
=
'\0'
;
if
(
lpApplicationName
)
{
found_file
=
make_lpApplicationName_name
(
lpApplicationName
,
name
,
sizeof
(
name
)
);
cmdline
=
(
lpCommandLine
)
?
lpCommandLine
:
lpApplicationName
;
}
else
found_file
=
make_lpCommandLine_name
(
lpCommandLine
,
name
,
sizeof
(
name
),
&
cmdline
);
if
(
!
found_file
)
{
/* make an early exit if file not found - save second pass */
SetLastError
(
ERROR_FILE_NOT_FOUND
);
return
FALSE
;
}
/* Warn if unsupported features are used */
if
(
dwCreationFlags
&
CREATE_SUSPENDED
)
...
...
@@ -1197,24 +1215,6 @@ BOOL WINAPI CreateProcessA( LPCSTR lpApplicationName, LPSTR lpCommandLine,
if
(
lpStartupInfo
->
dwFlags
&
STARTF_USEHOTKEY
)
FIXME_
(
module
)(
"(%s,...): STARTF_USEHOTKEY ignored
\n
"
,
name
);
/* Process the AppName or CmdLine to get module name and path */
name
[
0
]
=
'\0'
;
if
(
lpApplicationName
)
{
found_file
=
make_lpApplicationName_name
(
lpApplicationName
,
name
,
sizeof
(
name
)
);
cmdline
=
(
lpCommandLine
)
?
lpCommandLine
:
lpApplicationName
;
}
else
found_file
=
make_lpCommandLine_name
(
lpCommandLine
,
name
,
sizeof
(
name
),
&
cmdline
);
if
(
!
found_file
)
{
/* make an early exit if file not found - save second pass */
SetLastError
(
ERROR_FILE_NOT_FOUND
);
return
FALSE
;
}
/* When in WineLib, always fork new Unix process */
if
(
__winelib
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment