- Feb 10, 2020
-
-
Alexander Köplinger authored
Backport from https://github.com/mono/mono/pull/18080
-
- Feb 07, 2020
-
-
monojenkins authored
Apple removed `-t` switch from dsymutil in favor of `-num-threads` Co-authored-by: Alex Soto <alex@alexsoto.me>
-
- Feb 06, 2020
-
-
Alexander Köplinger authored
WebAssembly doesn't use our usual release branches yet. (cherry picked from commit a40e1ae6)
-
monojenkins authored
Addresses https://github.com/mono/mono/issues/18681 Co-authored-by: Alexis Christoforides <alexis@thenull.net>
-
monojenkins authored
Update the nunitlite submodule to pick up some fixes in the NUnit v3 outputwriter that are needed by xamarin-macios. Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
-
- Feb 04, 2020
-
-
Matt Sylvia authored
Use of `access_token` is now deprecated, switching to HTTP header ``` Please use the Authorization HTTP header instead, as using the `access_token` query parameter is deprecated. ``` (cherry picked from commit 2f74ab39)
-
monojenkins authored
Fixes https://github.com/mono/mono/issues/18676 . Co-authored-by: Zoltan Varga <vargaz@gmail.com>
-
- Jan 31, 2020
-
-
monojenkins authored
* [merp] MONO_DEBUG=no-gdb-stacktrace shouldn't disable MERP Only prevent `gdb` or `lldb` from being invoked. MERP is controlled by separate mechanisms --- configure flags for crash reporting and an explicit opt-in icall. The existing code collects crashed process data in-process, but it writes the data out (using mono_merp_invoke) in the forked child process. This is a bit surprising, but in the interest of not disturbing the code too much, this PR doesn't change that. We should revisit `dump_native_stacktrace` again in the future and rationalize these decisions. Addresses https://github.com/mono/mono/issues/18565 * Fix indentation Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
-
- Jan 29, 2020
-
-
monojenkins authored
Follow-up to https://github.com/mono/mono/pull/18228 since two parts wasn't enough to fix the size issue on 32bits devices. We now use three parts. Fixes https://github.com/mono/mono/issues/18614 Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
-
- Jan 28, 2020
-
-
Alexander Köplinger authored
Fixes bug #1048838, correct SF font not loading in VSMac Backport of https://github.com/mono/mono/pull/18566
-
- Jan 27, 2020
-
-
monojenkins authored
This causes an additional dependency of mono on libintl which we didn't have before. Reported by a user on gitter, it's problematic on macOS since it makes the mono binary depend on the libintl we ship in the Mono .pkg. It was introduced in Mono 6.6 by https://github.com/mono/mono/commit/18e0ebfe89be0a175d2f904b9bb1ec6816daa318 Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
-
monojenkins authored
Backport of #18590. Co-authored-by: Zoltan Varga <vargaz@gmail.com>
-
Ankit Jain authored
-
- Jan 25, 2020
-
-
monojenkins authored
[jit] Compute has_references correctly for gshared types whose constraint is a generic valuetype. Also emit write barriers correctly for these types. (#18562) Co-authored-by: Zoltan Varga <vargaz@gmail.com>
-
- Jan 23, 2020
-
-
monojenkins authored
* If a thread was suspended and doesn't have any managed stack, it was considered as terminated, but it wasn't really terminated because it can execute managed code again, and stop in a breakpoint so if the execution arrives in debugger_agent_breakpoint_from_context we reset the flag terminated to FALSE. * Adding terminated = FALSE in single_step_from_context. Co-authored-by: Thays Grazia <thaystg@gmail.com>
-
monojenkins authored
`jit_tls->interp_context` gets initialized lazily, that is, upon the first interpreter execution on a specific thread (e.g. via interp_runtime_invoke). However, with mixed mode the execution can purely happen in AOT code upon the first interaction with the managed debugger. Stack trace: ``` thread #1, name = 'tid_407', queue = 'com.apple.main-thread' frame #0: 0x0000000190aedc94 libsystem_kernel.dylib`__psynch_cvwait + 8 frame #1: 0x0000000190a0f094 libsystem_pthread.dylib`_pthread_cond_wait$VARIANT$armv81 + 672 frame #2: 0x000000010431318c reloadcontext.iOS`mono_os_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-os-mutex.h:219:8 frame #3: 0x0000000104312a68 reloadcontext.iOS`mono_coop_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-coop-mutex.h:91:2 frame #4: 0x0000000104312858 reloadcontext.iOS`suspend_current at debugger-agent.c:3021:4 frame #5: 0x000000010431be18 reloadcontext.iOS`process_event(event=EVENT_KIND_BREAKPOINT, arg=0x0000000145d09ae8, il_offset=0, ctx=0x0000000149015c20, events=0x0000000000000000, suspend_policy=2) at debugger-agent.c:4058:3 frame #6: 0x0000000104310cf4 reloadcontext.iOS`process_breakpoint_events(_evts=0x000000028351a680, method=0x0000000145d09ae8, ctx=0x0000000149015c20, il_offset=0) at debugger-agent.c:4722:3 frame #7: 0x000000010432f1c8 reloadcontext.iOS`mono_de_process_breakpoint(void_tls=0x0000000149014e00, from_signal=0) at debugger-engine.c:1141:2 frame #8: 0x000000010430f238 reloadcontext.iOS`debugger_agent_breakpoint_from_context(ctx=0x000000016f656790) at debugger-agent.c:4938:2 frame #9: 0x00000001011b73a4 reloadcontext.iOS`sdb_breakpoint_trampoline + 148 frame #10: 0x00000001008511b4 reloadcontext.iOS`reloadcontext_iOS_Application_Main_string__(args=0x000000010703a030) at Main.cs:14 frame #11: 0x00000001010f9730 reloadcontext.iOS`wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 272 frame #12: 0x00000001042fd8b8 reloadcontext.iOS`mono_jit_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at mini-runtime.c:3162:3 frame #13: 0x0000000104411950 reloadcontext.iOS`do_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at object.c:3052:11 frame #14: 0x000000010440c4dc reloadcontext.iOS`mono_runtime_invoke_checked(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, error=0x000000016f656ff8) at object.c:3220:9 frame #15: 0x0000000104415ae0 reloadcontext.iOS`do_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5184:3 frame #16: 0x00000001044144ac reloadcontext.iOS`mono_runtime_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5281:9 frame #17: 0x0000000104414500 reloadcontext.iOS`mono_runtime_run_main_checked(method=0x0000000145d09ae8, argc=1, argv=0x000000016f6570d0, error=0x000000016f656ff8) at object.c:4734:9 frame #18: 0x00000001042d3b54 reloadcontext.iOS`mono_jit_exec_internal(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1320:13 frame #19: 0x00000001042d39a4 reloadcontext.iOS`mono_jit_exec(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1265:7 frame #20: 0x0000000104597994 reloadcontext.iOS`::xamarin_main(argc=5, argv=0x000000016f657a80, launch_mode=XamarinLaunchModeApp) at monotouch-main.m:483:8 frame #21: 0x00000001008510dc reloadcontext.iOS`main(argc=5, argv=0x000000016f657a80) at main.m:104:11 frame #22: 0x0000000190af8360 libdyld.dylib`start + 4 [...] * thread #5, name = 'Debugger agent', stop reason = signal SIGABRT * frame #0: 0x0000000190aedec4 libsystem_kernel.dylib`__pthread_kill + 8 frame #1: 0x0000000190a0d724 libsystem_pthread.dylib`pthread_kill$VARIANT$armv81 + 216 frame #2: 0x000000019095d844 libsystem_c.dylib`abort + 100 frame #3: 0x00000001045871b4 reloadcontext.iOS`log_callback(log_domain=0x0000000000000000, log_level="error", message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", fatal=4, user_data=0x0000000000000000) at runtime.m:1213:3 frame #4: 0x0000000104544fc8 reloadcontext.iOS`eglib_log_adapter(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", user_data=0x0000000000000000) at mono-logger.c:405:2 frame #5: 0x000000010456093c reloadcontext.iOS`monoeg_g_logstr(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, msg="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n") at goutput.c:134:2 frame #6: 0x0000000104560598 reloadcontext.iOS`monoeg_g_logv_nofree(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, format="* Assertion at %s:%d, condition `%s' not met\n", args="e\x12z\x04\x01") at goutput.c:149:2 frame #7: 0x000000010456061c reloadcontext.iOS`monoeg_assertion_message(format="* Assertion at %s:%d, condition `%s' not met\n") at goutput.c:184:22 frame #8: 0x0000000104560674 reloadcontext.iOS`mono_assertion_message(file="../../../../../mono/mini/interp/interp.c", line=7176, condition="context") at goutput.c:203:2 frame #9: 0x000000010459b570 reloadcontext.iOS`interp_get_resume_state(jit_tls=0x000000014900d000, has_resume_state=0x000000016fc7a9f4, interp_frame=0x000000016fc7a9e8, handler_ip=0x000000016fc7a9e0) at interp.c:7176:2 frame #10: 0x0000000104319420 reloadcontext.iOS`compute_frame_info(thread=0x0000000104fe4130, tls=0x0000000149014e00, force_update=1) at debugger-agent.c:3422:3 frame #11: 0x0000000104320d40 reloadcontext.iOS`thread_commands(command=1, p="", end="", buf=0x000000016fc7acf8) at debugger-agent.c:9048:3 frame #12: 0x000000010431cca0 reloadcontext.iOS`debugger_thread(arg=0x0000000000000000) at debugger-agent.c:10132:10 frame #13: 0x000000010447eb04 reloadcontext.iOS`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000000016fc7b000) at threads.c:1232:3 frame #14: 0x000000010447e788 reloadcontext.iOS`start_wrapper(data=0x000000028203ef40) at threads.c:1305:8 frame #15: 0x0000000190a11d8c libsystem_pthread.dylib`_pthread_start + 15 [...] ``` Thanks to @drasticactions for helping me to reproduce. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050615 Co-authored-by: Bernhard Urban-Forster <bernhard.urban@xamarin.com>
-
- Jan 21, 2020
-
-
monojenkins authored
[2019-12] [jit] Compute the instance size/alignment correctly for gshared types whose constraint is a generic valuetype. (#18529) * [jit] Compute the instance size/alignment correctly for gshared types whose constraint is a generic valuetype. Fixes https://github.com/mono/mono/issues/18455 . * [jit] Simplify code Fix some line damage Co-authored-by: Zoltan Varga <vargaz@gmail.com> Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
-
- Jan 16, 2020
-
-
monojenkins authored
See https://github.com/mono/xsp/pull/88 Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
-
monojenkins authored
* Don't run `make install` in boehm submodule * Simplify logic Co-authored-by: Jo Shields <directhex@apebox.org>
-
monojenkins authored
[2019-12] [wasm] Improve virtualenv installation script Backport of #18190. /cc @lewurm @marek-safar
-
monojenkins authored
* [arm] account for signed bit when calculating offset to PLT entry * mask only will do the job Co-authored-by: Bernhard Urban-Forster <bernhard.urban@xamarin.com>
-
- Jan 15, 2020
-
-
monojenkins authored
* [loader] ReflectionOnlyLoad(byte[]) should not apply binding redirects Match .NET Framework behavior. Addresses https://github.com/mono/mono/issues/18388 * [tests] ReflectionOnlyLoad(byte[]) should not apply binding redirects Regression test for https://github.com/mono/mono/issues/18388 Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
-
monojenkins authored
* [sgen] Don't subtract twice the nursery size from max_heap_size We were subtracting the nursery size when initializing max_heap_size as well as adding it to the allocated_heap when allocating the nursery (alloc_nursery). * [sgen] Trigger collection if failing to allocate los section If the memory governor says we are exceeding the max_heap_size by allocating a los section (1MB) for a new los object, attempt to clear some space by triggering a major collection, before completely bailing out. Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
-
- Jan 12, 2020
-
-
Ankit Jain authored
-
- Jan 10, 2020
-
-
Ankit Jain authored
-
monojenkins authored
[2019-12] [memory barrier] use pagesize determined by helper `limits.h` doesn't always define `PAGESIZE` properly (e.g. iOS), so it would fall back to `0x1000` (4096) but it's really `0x4000` (16384) on iOS. We already have a helper in the runtime to determine the pagesize, so let's use that instead. Fixes https://github.com/mono/mono/issues/18273 Backport of #18383. /cc @lewurm
-
- Jan 09, 2020
-
-
Martin Baulig authored
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
-
Alexis Christoforides authored
[FileSystemWatcher] Fix wrong behaviour when move multiple files out of watched folder on mac (#41963) (#18225) Backport of https://github.com/dotnet/corefx/pull/41963 Fixes https://github.com/mono/mono/issues/16778
-
Ankit Jain authored
-
monojenkins authored
Updated test to follow in dotnet/runtime Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
-
- Jan 08, 2020
-
-
Ankit Jain authored
-
- Jan 07, 2020
-
-
monojenkins authored
[2019-12] [jit] Avoid passing a vtable argument to DIM methods when making calls out of gsharedvt methods. (#18365) * [jit] Avoid passing a vtable argument to DIM methods when making calls out of gsharedvt methods. Fixes https://github.com/mono/mono/issues/18276.
-
Ankit Jain authored
-
monojenkins authored
[2019-12] Add SignedCms to the TypeForwards in the System.Security.Cryptography.Pkcs facade (#18362) * Add SignedCms to the typeforwards in the System.Security.Cryptography.Pkcs facade * Added additional missing types from System.Security.Cryptography.Pkcs. * It would be nice if the files I added had namespaces ;-) * [csproj] Update project files * Bump API snapshot submodule
-
- Jan 06, 2020
-
-
monojenkins authored
* [metadata] Size 0 Blob heap is ok when resolving assembly refs Sometimes ILasm can produce images with a Blob heap of size 0. In cases where we're loading assembly references from such an image, the hash (which is optional) can be at index = 0 and the Blob heap size is also 0. Also: add the hash value to the output of `monodis --assemblyref` * [metadata] Add a separate assertion for the index == size == 0 case And a comment explaining how it is likely to be triggered. If the assembly is reasonable the caller of mono_metadata_blob_heap should be updated to use mono_metadata_blob_heap_null_ok instead * [bcl] Allow Mono's ILASM to produce a size 0 Blob heap ECMA 335 II.24.2.4 says that the user string and blob heaps should have an entry at index 0 consisting of the single byte 0. However .NET Framework (and .NET Core) ilasm will entirely omit the Blob heap (that is, create a blob heap entry of size 0) if it is not needed. This PR changes Mono's ILASM to emit the initial byte on demand only if one of the MetaDataStream.Add() methods is called. Otherwise we will also emit a stream of size 0. This is needed to compile some test cases. * [tests] Add regression test for loading assemblies with size 0 Blob heap Depends on ILASM that can emit a size 0 Blob heap
-
- Jan 03, 2020
-
-
monojenkins authored
[2019-12] Set inited flag _after_ TermInfoDriver initialisation completes This flag was causing issues when accessing console properties on concurrent threads during TermInfoDriver initialisation. Fixes #18317 Backport of #18318. /cc @steveisok @nagytech
-
Steve Pfister authored
* Bump to mono/corefx@b7e7440 Backport of https://github.com/mono/mono/pull/18310 * Forgot the test tweak
-
monojenkins authored
The behaviour expected of filter exceptions is: -> throw in a async task with a try catch in the caller -> don't stop -> throw in a new thread with a try catch in the caller -> stop -> throw in the main thread without any try catch -> stop (#18333) Including a new test to test the fix of #17601. Fixing #16588, create a while 1 to stops the program execution when an exception is thrown and no try catch is found and MONO_DEBUG=suspend-on-unhandled. Fixes #17601 Fixes #16588 Co-authored-by: Thays Grazia <thaystg@gmail.com>
-
- Jan 02, 2020
-
-
monojenkins authored
[2019-12] Use byte-aligned LLVM loads and stores for unaligned mini IR loads and stores. Should fix https://github.com/mono/mono/issues/18221. Backport of #18296. /cc @lambdageek @imhameed
-
- Jan 01, 2020
-
-
monojenkins authored
Fixes #16513. Co-authored-by: Martin Baulig <mabaul@microsoft.com>
-