Skip to content
Snippets Groups Projects
Commit f5bfa728 authored by Francisco Casas's avatar Francisco Casas Committed by Henri Verbeet
Browse files

vkd3d-shader/hlsl: Reorder default values for matrices for SM4.

Default value initializers behave differently than regular initializers
for matrices on SM4 profiles.

While regular initializers assign the rhs elements in reading-order
(completing one row at the time), default initializers assing the rhs
elements in Chinese reading-order (completing one column at the time).

So after lowering a default value to a constant, the index of the
component to which this default value is stored is computed to meet
this expectation. This can be done because the default values.

For reference, compiling this shader:

    row_major int2x3 m = {1, 2, 3, 4, 5, 6};

    float4 main() : sv_target
    {
        return float4(m[0][0], 99, 99, 99);
    }

gives the following buffer definition:

    // cbuffer $Globals
    // {
    //
    //   row_major int2x3 m;                // Offset:    0 Size:    28
    //      = 0x00000001 0x00000003 0x00000005 0x00000000
    //        0x00000002 0x00000004 0x00000006
    //
    // }

Given that the matrix is column-major, m's default value is actually
{{1, 3, 5}, {2, 4, 6}}, unlike the {{1, 2, 3}, {4, 5, 6}} one would
expect in a regular initializer.

SM1 profiles assign the elements in regular reading order.
parent ab01fedc
Branches
Tags
1 merge request!787vkd3d-shader/hlsl: Parse and write default values.
Pipeline #27469 skipped
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment